More > JRiver Media Center 27 for Linux

How To Revert ModernCard Dark Under Linux

<< < (4/5) > >>

JimH:

--- Quote from: Awesome Donkey on November 02, 2020, 06:45:07 am ---If it's the flash of the import progress in the bottom of the tree that I'm thinking of, it's intended. I believe it was added to MC some time ago (seems like several years at least) as a way to notify and catch the user's attention at what's happening.

--- End quote ---
It should only happen on initial import to alert the user that MC will automatically import files.  If files exist in the library, it should not happen.

Jamil:

--- Quote from: Awesome Donkey on November 02, 2020, 06:45:07 am ---If it's the flash of the import progress in the bottom of the tree that I'm thinking of, it's intended. I believe it was added to MC some time ago (seems like several years at least) as a way to notify and catch the user's attention at what's happening. If it didn't appear in the old Dark Edition skin, that's technically a bug in the skin.

I'll check the old Dark Edition and the new one here in a bit to see if I'm right on that assumption. I'll probably check the other ModernCards skins as well.

--- End quote ---

The first time ever seeing this was with the change to ModernCards Dark.  I have never seen this until this skin was changed.

If this was indeed an intentional change, then ModernCards Dark (prior to revision) broke it.  This is good, because it is a bad change.

Awesome Donkey:
It's because all the Modern Cards skins technically have a bug where the intended import flashing isn't shown. I just verified it; all of them (including the default Grey Edition skin) except the new Dark Edition, doesn't display the expected flashing when running an import.

Now that begs the question... should the Modern Cards skins be updated to fix it to display the intended flashing or should the Dark Edition skin be updated to omit it like the others?

I do suspect if it's fixed other users may not like that change. Honestly, I never noticed it was missing, as I'm not really a fan of the flashing on import myself. If the import flashing was optional, that might be an acceptable compromise on both sides of the fence.

JimH:
It shouldn't flash during import.

Awesome Donkey:
Okay then, when I get a little time I'll attempt to fix it in the Dark Edition skin and submit a patch (unless marko sees this topic and beats me to it). :P

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version