Windows > Third Party Plug-ins, Programs, and Skins
>>> BRAND NEW SKIN: Dream in Blue <<<
zybex:
There's no renaming. It just doesn't re-download because it sees there's already a file with that name (so it skips downloading).
If the ZIP file doesn't exist, there's a popup asking "MC is about to install a Component. Continue?". Then it downloads the ZIP and installs (without overwriting - bug #2)
If the ZIP file already exists, there's no popup. It just extracts the existing one without asking (bug #1)
This is easy to test.
--- Quote ---You are letting MC run the mjp from the download directly with packageinstaller, right?
--- End quote ---
I'm double-clicking on the downloaded .MJP, which installs the skin and starts MC.
bob:
--- Quote from: zybex on February 16, 2021, 04:34:07 pm ---There's no renaming. It just doesn't re-download because it sees there's already a file with that name (so it skips downloading).
If the ZIP file doesn't exist, there's a popup asking "MC is about to install a Component. Continue?". Then it downloads the ZIP and installs (without overwriting - bug #2)
If the ZIP file already exists, there's no popup. It just extracts the existing one without asking (bug #1)
This is easy to test.
I'm double-clicking on the downloaded .MJP, which installs the skin and starts MC.
--- End quote ---
The downloaded .mjp with the updated version number?
It's up to packageinstaller to upload a new one if the version changes or just overwrite the existing one, kind of looks like it's not doing that.
zybex:
OK, some more findings:
- this only happens because I had the old 877.zip file in the downloads folder. On normal process this file will not be left there.
- the unzipping DOES overwrite older files, if the new version has a newer Modified Date. This is OK. It didn't work for me because during my tests I was copying the Skin folder, so the files all got today's date (so were not overwritten when unzipping)
So this changes things:
- it still merges new files with old files on the skin folder; the folder should be cleared before installing. this also avoids any potential problem due to file dates.
- if user downloads the ZIP manually then the .MJP process fails. Maybe MC should ignore/overwrite an existing ZIP
zybex:
--- Quote from: bob on February 16, 2021, 04:51:33 pm ---The downloaded .mjp with the updated version number?
It's up to packageinstaller to upload a new one if the version changes or just overwrite the existing one, kind of looks like it's not doing that.
--- End quote ---
Yes, the MJP is updated, I have both of them for testing. One says "<Version>1.0</Version>" and the other "<Version>1.1</Version>". Both point to the same url of file 877.zip.
It doesn't matter which one you execute - it downloads the ZIP and extracts it, the URL is the same. Except, I already had the old 877.zip on my downloads folder, and in that case it seems the download is skipped.
bob:
--- Quote from: zybex on February 16, 2021, 04:54:39 pm ---Yes, the MJP is updated, I have both of them for testing. One says "<Version>1.0</Version>" and the other "<Version>1.1</Version>". Both point to the same url of file 877.zip.
It doesn't matter which one you execute - it downloads the ZIP and extracts it, the URL is the same. Except, I already had the old 877.zip on my downloads folder, and in that case it seems the download is skipped.
--- End quote ---
Weird, I had no idea that packageinstaller cared at all about the download folder. I agree on the overwrite of the existing folder.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version