Topic: Composer View and Composer Images [Solved] (Read 2052 times)

Manfred · « **on:** August 30, 2021, 09:14:06 am »

I have created a Composer View with Composer->Work->Album for Classical Music.

It looks like a mess. Most of the images under C:\Users\...\AppData\Roaming\J River\Media Center 28\Cover Art\Composers are "empty".

Google finds an "empty" image like that of Robert Schumann (see attachment).

Why does "Get Composer Images from Google" only rarely find the right image (manually doing it in Google always leads to a result)?

Matt · « **Reply #1 on:** August 30, 2021, 09:20:13 am »

I get a good image for Schumann. It's attached.

Manfred · « **Reply #2 on:** August 30, 2021, 09:56:19 am »

Why that? What is the difference?

Has one to use the MC Standard Composer View and then modify it?

DJLegba · « **Reply #3 on:** August 30, 2021, 10:14:16 am »

Quote from: Manfred on August 30, 2021, 09:56:19 am

Why that? What is the difference?

Has one to use the MC Standard Composer View and then modify it?

I suspect the difference in this case is that your composer is entered as "Schumann, Robert" and Matt's is entered as "Robert Schumann".

Matt · « **Reply #4 on:** August 30, 2021, 10:16:52 am »

We don't handle last, first as a name.

Maybe we could try to straighten out names? Is this common?

Matt · « **Reply #5 on:** August 30, 2021, 10:20:49 am »

Next build:
Changed: During composer image lookup, if the name is last, first, it will be swapped around.

Manfred · « **Reply #6 on:** August 30, 2021, 10:33:30 am »

Thank you!

I had standardized the composer name like this:Vivaldi, Antonio (1678-1741)

Should I remove the brackets an/or store the information in a different Field?

Matt · « **Reply #7 on:** August 30, 2021, 10:34:50 am »

The years are probably still going to throw us off. You might think about using a different field for that.

Manfred · « **Reply #8 on:** August 30, 2021, 11:38:14 am »

I will introduce a field like Composer Information. At the same time I will change also the order of the Name because typically from NativeDSD etc. the Composer Name comes like Robert Schumann.

Thank you!

dtc · « **Reply #9 on:** August 30, 2021, 11:45:38 am »

Quote from: Matt on August 30, 2021, 10:34:50 am

The years are probably still going to throw us off. You might think about using a different field for that.

The dates are a pretty common part of composer names. If you are doing a swap, maybe also find 2 parenthesis and delete them and anything between them before doing the lookup. Seems like they are not very likely to part of any composers name.

Matt · « **Reply #10 on:** August 30, 2021, 11:51:08 am »

Next build:
Changed: Composer lookup for images removes anything in parenthesis (since that's often dates).

Matt · « **Reply #11 on:** August 30, 2021, 12:10:22 pm »

We were already flipping the names and removing dates. So never mind what I said about changing a coming build. Should be good already.

Not sure why it wasn't working for the original poster?

Matt · « **Reply #12 on:** August 30, 2021, 12:18:40 pm »

I just entered this composer and still got the right image I posted earlier (I know the dates are wrong!):
Schumann, Robert (1678-1741)

Manfred · « **Reply #13 on:** August 30, 2021, 12:24:37 pm »

Thank you Matt - I will wait until next build and then test it.

Matt · « **Reply #14 on:** August 30, 2021, 12:39:50 pm »

Quote from: Manfred on August 30, 2021, 12:24:37 pm

Thank you Matt - I will wait until next build and then test it.

There are no new changes coming.

Maybe post the exact names you're using for a composer that fails?

Manfred · « **Reply #15 on:** August 30, 2021, 01:11:47 pm »

Sorry I did not read your post correctly.

I tried with Johann Sebastian Bach as well as Robert Schumann and it does not work - something is wrong!

Matt · « **Reply #16 on:** August 30, 2021, 01:13:52 pm »

I just did a lookup of "Johann Sebastian Bach" and got an image for that as well.

Could you have something blocking internet access? We're using Google to find the images.

Manfred · « **Reply #17 on:** August 30, 2021, 01:16:44 pm »

Pjotr Iljitsch Tchaikowski works and also Get Artist Images ... works. Strange!

Matt · « **Reply #18 on:** August 30, 2021, 01:18:27 pm »

Quote from: Manfred on August 30, 2021, 01:16:44 pm

Pjotr Iljitsch Tchaikowski works and also Get Artist Images ... works. Strange!

Make sure you're using Cover Art > Get Composer Images From Google...

That's been what I have been testing.

DJLegba · « **Reply #19 on:** August 30, 2021, 01:19:11 pm »

Quote from: Manfred on August 30, 2021, 01:16:44 pm

Pjotr Iljitsch Tchaikowski works and also Get Artist Images ... works. Strange!

I'm using Schumann, Robert (1810-1856) and get composer image worked for me. 64-bit 28.0.49 here.

Manfred · « **Reply #20 on:** August 30, 2021, 01:26:56 pm »

Quote

Make sure you're using Cover Art > Get Composer Images From Google...

Yes I do that. MC 28.0.53 64 bit

Very Strange - something is wrong in my environement.

Manfred · « **Reply #21 on:** August 30, 2021, 01:33:03 pm »

I deleted the complete composer folder. What seems to work is that MC via Google could identify the Naming Wagner, Richard (1989-1999) to Richard Wagner but the .jpg is empty but not all the times.

Manfred · « **Reply #22 on:** August 31, 2021, 11:22:16 am »

For testing I created some test files in the main library on my workstation (I have client server setup and don't use the main lib on my workstation normally). Workstation is directly connected via 1Gb ethernet to the router. Internetspeed is 1 Gbit.

1. Same Problem.
2. If I disable MS Antivirus - same problem.

Could it be that a filter at my Internet Provider deletes the *.jpg?
Strange is that MC creates a file like Richard Wagner.jpg but the file has no content, no dimension.

Any further idea?

Matt · « **Reply #23 on:** August 31, 2021, 11:30:15 am »

You could look in the log for a URL we're trying that is failing and try that manually?

Manfred · « **Reply #24 on:** August 31, 2021, 03:30:04 pm »

I provided a log with two searches (ravel, Schumann).

Matt · « **Reply #25 on:** August 31, 2021, 04:24:41 pm »

You have piles of these:
88790220: 3964: Import: AddFile: Skipping Previously Removed: M:\Audio\(Multiple Artists)\Stereoplay - Natural Bass\Charly Antolini - Jammin'.flac

Can you reset logging, lookup just Schumann, and then grab the log right away?

It looks like you might be getting a Google account page instead of the results page, but I'm not sure why.

Thanks.

Manfred · « **Reply #26 on:** August 31, 2021, 04:37:58 pm »

Here it is.

Matt · « **Reply #27 on:** August 31, 2021, 04:53:55 pm »

I'm riddled.

On my computer, it's this:
0003379: 17728: Reader: CWinINetReader::Thread: Start
0003379: 17728: Reader: CWinINetReader::Thread: https://www.google.com/images?q=Robert%2BSchumann&tbs=isch:1&lh=en&gbv=2&sa=1&aq=f&aqi=g10&biw=1280&bih=1024
0003379: 17728: Reader: CWinINetReader::Connect: Start
0003379: 17728: Reader: CWinINetReader::Connect: Finish (0 ms)
0003379: 17728: Reader: CWinINetReader::DownloadFromHTTPURL: Start
0003379: 17728: Reader: CWinINetReader::DownloadFromHTTPURL: HttpOpenRequest successful
0003581: 17728: Reader: CWinINetReader::DownloadFromHTTPURL: HttpSendRequest successful
0003581: 17728: Reader: CWinINetReader::DownloadFromHTTPURL: Retry needed, trying again...
0003581: 17728: Reader: CWinINetReader::Connect: Start
0003581: 17728: Reader: CWinINetReader::Connect: Finish (0 ms)
0003582: 17728: Reader: CWinINetReader::DownloadFromHTTPURL: HttpOpenRequest successful
0003717: 17728: Reader: CWinINetReader::DownloadFromHTTPURL: HttpSendRequest successful
0003717: 17728: Reader: CWinINetReader::DownloadFromHTTPURL: Success
0003717: 17728: Reader: CWinINetReader::DownloadFromHTTPURL: Finish (337 ms)
0003717: 17728: Reader: CWinINetReader::Thread: Finish (338 ms)
0003718: 19840: Reader: CWinINetReader::Open: Finish (338 ms)
0004258: 19840: Reader: CWinINetReader::Read: InternetReadFile returned true with zero bytes read: EOF
0004277: 19840: Reader: CWinINetReader::Close: Start
0004277: 19840: Reader: CWinINetReader::Close: Finish (0 ms)
0004292: 19840: Reader: CWinINetReader::Open: Start
0004292: 19840: Reader: CWinINetReader::Open: Opening https://upload.wikimedia.org/wikipedia/commons/f/fa/Robert_Schumann_1839.jpg

On yours it's this:
0010023: 10432: Reader: CWinINetReader::Open: Start
0010023: 10432: Reader: CWinINetReader::Open: Opening https://www.google.com/images?q=Robert%2BSchumann&tbs=isch:1&lh=en&gbv=2&sa=1&aq=f&aqi=g10&biw=1280&bih=1024
0010024: 2384: Reader: CWinINetReader::Thread: Start
0010024: 2384: Reader: CWinINetReader::Thread: url: https://www.google.com/images?q=Robert%2BSchumann&tbs=isch:1&lh=en&gbv=2&sa=1&aq=f&aqi=g10&biw=1280&bih=1024
0010024: 2384: Reader: CWinINetReader::Connect: Start
... some stuff I trimmed ...
0011116: 10432: Reader: CWinINetReader::Open: Start
0011116: 10432: Reader: CWinINetReader::Open: Opening http://www.google.com/policies/faq/
0011117: 800: Reader: CWinINetReader::Thread: Start
0011117: 800: Reader: CWinINetReader::Thread: url: http://www.google.com/policies/faq/
0011117: 800: Reader: CWinINetReader::Connect: Start
0011117: 800: Reader: CWinINetReader::Connect: Finish (0 ms)

So for some reason Google isn't returning matches.

Matt · « **Reply #28 on:** August 31, 2021, 04:59:29 pm »

If you just visit this URL do you get matches:
https://www.google.com/images?q=Robert%2BSchumann&tbs=isch:1&lh=en&gbv=2&sa=1&aq=f&aqi=g10&biw=1280&bih=1024

Manfred · « **Reply #29 on:** September 01, 2021, 12:54:06 am »

Yes URL works on iPad and Windows.

MikeO · « **Reply #30 on:** September 01, 2021, 05:32:30 am »

I use a simple surname, Beethoven, Mozart etc and it works mostly

The image name in the Cover Art folder must match ie Beethoven.jpg etc

You do get odd funnies, Weber gave me lovely picture of a kettle bar b q

It works anywhere in a category view where the Composer Tag is included

I strip dates etc where there are any just for consistency, I have views where I use a rule to limit my favorites

Matt · « **Reply #31 on:** September 01, 2021, 08:44:01 am »

I just emailed you a new JRTools to test. It will save the image URL lookup it downloads so we can see if it's like what we expect.

Thanks.

Manfred · « **Reply #32 on:** September 01, 2021, 12:34:01 pm »

I backup the old JRTools.dll in C:\Program Files\J River\Media Center 28
and
copied your new JRTools.dll into C:\Program Files\J River\Media Center 28

I deleted the Composer folder and run GetComp... again but I did not find a file like Image Lookup.txt (logging disabled or enabled).

What is strange, is that if I do what MikeO had written (I tested 5 examples Rachmaninoff, Mendelson, Prokofiev, Schumann, Wagner)

Quote

I use a simple surname, Beethoven, Mozart etc and it works mostly

it works - very strange!

Matt · « **Reply #33 on:** September 01, 2021, 12:46:52 pm »

It only does the lookup if the image isn't already there. You might need to restart after deleting them all.

Manfred · « **Reply #34 on:** September 01, 2021, 12:47:37 pm »

I rebooted my server. No Lookup.txt

Matt · « **Reply #35 on:** September 01, 2021, 12:59:02 pm »

I just copied that JRTools and got a C:\Image Lookup.txt after doing a lookup. That's what I would expect, so I'm not sure.

You could run as admin in case you don't have access to C:\ for some reason?

Manfred · « **Reply #36 on:** September 01, 2021, 01:44:02 pm »

I have access to C:\.

I think I know what does not work, its the comma "," between the second and first Name and the second Name must be first - for whatever reasons (language setting??? I have mixed settings: Win OS in German, MC in english with german/english metadata). If you use

Wagner Richard (1234-4567)
or
Wagner - Richard (1234-4567).

it works.
I tested it with several composers.

Matt · « **Reply #37 on:** September 01, 2021, 01:53:17 pm »

Next build will have this although I'm not sure it's what is happening to you:
Fixed: When flipping composer names between first and last, an extra space could stay at the front (might cause lookup problems).

Matt · « **Reply #38 on:** September 01, 2021, 02:28:01 pm »

I sent you a preview of the build you can test. Thanks!

Manfred · « **Reply #39 on:** September 01, 2021, 02:42:44 pm »

I installed the new release. What I learned you have to separate multiple name by - like "Weber - Carl - Maria" then it works.
"Weber - Carl Maria" does not work.

Matt · « **Reply #40 on:** September 01, 2021, 02:45:48 pm »

If you have multiple names I'm not sure. But earlier you had one name and said lookup was failing. Is it any better with the new build?

Matt · « **Reply #41 on:** September 01, 2021, 02:47:45 pm »

Also using a dash in the name isn't expected. First last or Last, first.

Manfred · « **Reply #42 on:** September 05, 2021, 04:52:29 am »

Hi Matt,

thank you very much for your support!

I solved it now a little bit different - I don't use the composer Images any more (they also are not the best art work).

I have now defined two View's

Classical with tree categories: Subgenre, Work, Album
Composer with two categories: Work, Album

and use thumbnail text for the composer. It looks then like this:

INTERACT FORUM

Author Topic: Composer View and Composer Images [Solved] (Read 2052 times)