More > JRiver Media Center 31 for Linux

More graceful SIGTERM?

<< < (2/2)

bob:

--- Quote from: Hendrik on May 26, 2023, 10:15:45 am ---Should probably trap TERM as well, its technically the correct one to use.

If someone wants instant shutdown, thats what KILL would be for.

--- End quote ---
Not seeing a lot of difference with regards to a non-daemon program between TERMINATE and HANGUP
I could add TERM though.

BryanC:

--- Quote from: bob on May 26, 2023, 01:32:26 pm ---We are NOT trapping either SIGTERM or SIGKILL. Both will simply exit messily.
Exiting via SIGHUP should be the same as hitting the x button or exit in MC. It exits the run loop and lets the program close normally (including signing out of any network DLNA devices which is what actually takes time).

--- End quote ---

I'm only testing with SIGHUP from here on (honestly I don't care if I'm using SIGHUP/SIGTERM as long as one of them works correctly).

It looks like SIGHUP is acting differently for me (using killall -HUP mediacenter31) than using the internal exit mechanisms. I just tested in a Debian 11 VM and could reproduce on a fresh install. I'm only testing right-click command history for brevity.

bob:

--- Quote from: BryanC on May 26, 2023, 01:59:33 pm ---I'm only testing with SIGHUP from here on (honestly I don't care if I'm using SIGHUP/SIGTERM as long as one of them works correctly).

It looks like SIGHUP is acting differently for me (using killall -HUP mediacenter31) than using the internal exit mechanisms. I just tested in a Debian 11 VM and could reproduce on a fresh install. I'm only testing right-click command history for brevity.

--- End quote ---
It's possible I suppose that exiting the mainloop isn't running the same sequence of closing/saving.
I'll take a look at it when I get a chance.
Thanks.

Navigation

[0] Message Index

[*] Previous page