More > JRiver Media Center 31 for Windows

Feature Request: Add (or modify) skinnable lock state icon for use within tabs

<< < (3/5) > >>

Matt:
The lock icon looks pretty good to me with the default skin.

Here's the layout code:
int nImageToTextSpacing = (int) GetJRSkinning()->GetSkinInfoInt(m_strSkinItemWindow, _T("ImageToTextSpacing"), 6, true, true, true);
int nLockSize = Layout.GetHeight(0.5);
rectLock = Layout.LayoutLeft(JRSize(nLockSize, nLockSize), nImageToTextSpacing, true);

HPBEME:
Well I am not a coder, Matt, you know that!  I can maybe… sort of… decipher some of it, but only enough to be dangerous and suggest something foolish for you to try.  But hey, that's right my wheelhouse!

I am guessing the 6 in ("ImageToTextSpacing"), 6, true, true, true) represents the margin to the left of tab text?  If so, what do things look like if you change that to 1 or 2?

Matt:
It only uses 6 if it doesn't find ImageToTextSpacing in the skin.  So maybe try setting that.

HPBEME:
I always set ImageToTextSpacing to 4 for all my skins. Sometimes 3 looks okay without being too tight, but larger numbers spread things out too much.  Bottom line, I always have a value set for that input, so it is not defaulting to 6

HPBEME:
In the attached picture, look at the highlighted portions around the lock icon and close button - you can see the distance from the text to the adjacent tab border is approximately 50% wider for the lock icon.

It's not that it looks bad, but it would definitely look better if the space around each icon were identical.  And just as importantly, it buys back precious tabbar real estate.  It may not look like much, but when you have 6 to 10 tabs open, that small reduction makes a big difference.

NOTE: I am showing the tab close buttons even though I don't personally use them.

Navigation

[0] Message Index

[#] Next page

[*] Previous page