More > JRiver Media Center 31 for Windows

Feature Request: Add (or modify) skinnable lock state icon for use within tabs

<< < (2/5) > >>

markf2748:

--- Quote from: HPBEME on July 11, 2023, 01:30:17 pm ---If our benevolent MC overlord could somehow make a lock indicator dot closer the tab text and reduce the excess space, that would be the ideal solution for me personally.
--- End quote ---
You should be able to skin that today (I last tested it back on 3.0.25):
https://yabb.jriver.com/interact/index.php/topic,135855.msg944695.html#msg944695

Another thought:  Since most of my tabs are locked all the time, use no icon for a locked tab, and a simple icon (maybe just a dot, or a small broken open circle, gentle warning) for indicating an unlocked tab.  Again, I would prefer to implement per Reply #1 for flexible location.

marko:

--- Quote from: markf2748 on July 12, 2023, 11:41:53 am ---Another thought:  Since most of my tabs are locked all the time, use no icon for a locked tab, and a simple icon (maybe just a dot, or a small broken open circle, gentle warning) for indicating an unlocked tab.  Again, I would prefer to implement per Reply #1 for flexible location.

--- End quote ---
Seriously, please, do not do that. Thanks :)

HPBEME:

--- Quote from: markf2748 on July 12, 2023, 11:41:53 am ---You should be able to skin that today (I last tested it back on 3.0.25):
https://yabb.jriver.com/interact/index.php/topic,135855.msg944695.html#msg944695

--- End quote ---
Obviously it can be skinned today - that is how I created the dot next to the tab text to begin with.  I can tweak tab-text/tab-icon spacing via the skin XML file, but I cannot squeeze the excess space around the dot itself (due to the fixed "envelope" around the lock sub-image).


--- Quote from: HPBEME on July 11, 2023, 01:30:17 pm ---The lock icon space is ~50% wider than the space around the tab close button.  If our benevolent MC overlord could somehow make a lock indicator dot closer to the tab text and reduce the excess space

--- End quote ---
This is where Matt comes in - create a way to remove that excess space (if possible).


--- Quote from: marko on July 12, 2023, 11:57:53 am ---Seriously, please, do not do that. Thanks :)

--- End quote ---
Agreed

Matt:
You might try editing InternalMarginLeft and InternalMarginRight in the skin to adjust the sizing.

HPBEME:

--- Quote from: Matt on July 12, 2023, 12:25:27 pm ---You might try editing InternalMarginLeft and InternalMarginRight in the skin to adjust the sizing.

--- End quote ---
I am very familiar with the split view tab settings and have fiddled with them an impressive amount the last couple of years ;D.  The problem is finding combinations of SplitTabView values that looks good for all 4 tab configurations: Unlocked tab show close button, Unlocked tab hide close button, Locked tab show close button, Locked tab hide close button.

If I narrow the margins to reduce the excess space around the lock icon (which I have customized as a "dot") then unlocked tabs looked terrible because the text/tab border are now too close.  If I increase margins for a pleasing amount of space around the tab text, that results in excessive space around the tab lock icon (which brings us full circle).

And as I've noted in an couple of posts above, the fixed space around the lock icon is 50% wider than the fixed space around the tab close button.  Presumably that is related to the tab lock icon being a sub-image in the small icons image file (used by all skins), whereas the tab close button is a dedicated skin specific image.  If the lock icon and tab close button image "envelopes" were identical, it might be possible to adjust the margins and image offsets to get what I am after (but I'm not positive... it still may not work).

Can you do that? Does that make sense? Hopefully all that didn't just muddy the waters further.

Navigation

[0] Message Index

[#] Next page

[*] Previous page