Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[marko]

Could it really be as simple as this?

I noticed this morning that the 'remove empty folders?' dialogue didn't fire when it should have.

I happened to notice that MC's status bar was reading "saving tags (1 remaining)"

It was waiting to save the new rating I'd just given the currently playing song.

Using some file copies, I've found I can reproduce this 100% here.

If it's waiting to save tags, it doesn't ask about empty folders, if any tagging is all done, then it does ask about empty folders.


Could somebody test this theory and report back?

cheers,

-marko.

[KingSparta]

interesting, that does sound familiar

[risingdamp]

Well done marko!

[Alex B]

I tested this and can confirm.

I guess this explains why I haven't been able to reproduce the "empty folders not removed" bug. I am usually overcautious and don't do file operations when something else is still going on.

[marko]

thanks for testing. now we all know how to avoid the problem.

The next question, for jriver I suppose, is...

Now that the problem has been identified, can we expect a fix?

[Matt]

Empty folder checking and removal is run after all queued tagging is completed. 

If there are still files in the tagging thread's queue, you won't be asked about cleanup until it has finished.

This is by design since the final change(s) could have been to move files into a folder that was otherwise empty.

[marko]

OK, but what I'm seeing here is that when the tagging is complete, the prompt doesn't arrive.

Here are the steps I used to reproduce the bug:

start playback of a track and right away, change its rating. The status bar displays "saving tags (1 remaining)"

Next I select an albums' worth of files that I know are the only files in the containg folder and press shift+delete, then enter.

The files are deleted. There is no prompt. You say this is normal.

I stop playback and the status bar changes to "done saving tag changes"

The prompt to remove the empty folder never appears, and as you say it should, I guess that's a bug.
If you try the steps outlined above, hopefully you will see the behaviour I'm referring to. If you do, could you let us know if it's easily fixable?

Cheers,

-marko.

[Alex B]

change its rating. The status bar displays "saving tags (1 remaining)"

Of course, this happens only if the Ratings field is selected to be written to the files.

I have not done that. I keep the ratings only in the library. Otherwise I would need to update my file backups all the time because of the constantly changing ratings.

However, any pending tag write is good for reproducing the bug.

[Matt]

Thanks everyone.  This will be fixed next build. 

Sorry to anyone we said this to: "No, really, you have hidden files somewhere -- that's why MC isn't asking."

[marko]

good to be putting this one to bed.

thank you.