Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Dean Roddey]

Hey guys, a CQC customer was having trouble loading his exported XML file and I checked it out and one of the generated file names was 262 characters, which is over the legal length of 260, so Windows APIs were choking on the resulting path.

Are you guys doing any truncation at all, and this just happened to be slightly over, or are you doing truncation and are accidentally allowing it to get a little over the line?

[Matt]

MC shouldn't ever be renaming files to be longer than MAX_PATH.

However, MAX_PATH is actually a soft limit, and it's easy to use Windows Explorer to make a file longer than this limit. (you can rename a parent folder of a long filename, etc.)  After this, Explorer itself will be confused.

In my opinion this is a filesystem bug.  In MC, we're careful to use a new define MAX_PATH_SAFE that's something much larger than 260. (1024 or more)  We also refuse to import files with too long of filenames because we know they'll just cause problems later in the program with Windows API calls.

So I'm not sure if that answers your question or not.  Just let us know if there are specific places in MC where you think we need more filename length checking.

Best,
-Matt

[Dean Roddey]

AFAIK, this file got created by just the usual ripping process, not by any import scenario or anything. The file name was:

\\Server\Shared Music\Beethoven (Cleveland Orchestra, George Szell)\Symphony No. 1, Symphony No. 6 -Pastoral-, -Egmont- Overature\Symphony No. 6 in F Major, Op. 68 _Pastoral_, I. Awakening of Cheerful Feelings Upon Arrival in the Country - Allegro ma non tropp

Now, what might have tripped you up is that he moved the files (via JR's utilities) from a UNC share based path, to a shared drive based path, and then back to a UNC based path. So perhaps somewhere in that operation, the extra characters got added?