More > Media Center 17
Commercial skipping
raym:
After a few days of ad-free bliss, I can make some real comments. ;D
1/ We definitely need the cut points represented on the OSD somehow. Perhaps as vertical lines along the time bar? When one is missed, for example, it would be helpful to see if the expected cut point actually existed as well as seeing where the next one is.
2/ The EDL sidecars aren't getting cleaned up when I delete the source file. This is pretty important as I already have numerous orphaned files floating around and it's likely to get out of hand fast!
Thanks.
Matt:
Do you still think it's skipping skips? I could not explain why that would happen from your post above, but obviously the code hasn't been fire tested a lot yet.
Maybe you could provide a step-by-step and an EDL if you think there's a problem.
Thanks.
babgvant:
Ran through a full test last night. Very happy with the implementation. If the scrub was marked it would be just about perfect :)
babgvant:
Did some more testing and it would be really nice if there was an easier way to skip back to the last skip point (1) and skip forward (2) to the end of the current commercial segment.
Use case 1:
- the last bit of a show is incorrectly marked as a commercial so the skip occurs before the end of the show, when the skip occurs we should be able to get back to the skip point via a single key press
Use case 2:
- after returning to the show segment from 1, we should be able to reexecute the skip to the beginning of the next show segment
Thanks
JustinChase:
--- Quote from: Matt on October 12, 2011, 10:52:11 am ---With the help of Andrew Van Til (senior editor of Missing Remote), we're adding commercial skipping support to the video playback engine.
--- End quote ---
Wow, what crazy timing!
I seriously just walked away from the HTPC in the living room after confirming that I now have hands free commercial skipping working with WMC and wtv files, using Andrew's DTBAddin plugin and comskip!
I walked in here, wrote a thank you to the author of MC-TVConverter for making the change that allowed it to happen.
I popped over here to see what was new, and there's this post. Incredible timing.
Good news is, that workflow can be very easily modified to get me the edl for ts recordings, a single digit change I think. ::)
--- Quote from: babgvant on October 12, 2011, 11:22:43 am ---...skipping should be temporarily disabled until the position that you skipped back from has been passed. The use case is a place where detection is wrong, usually where the last couple seconds of a show segment has been misidentified.
--- End quote ---
another use case is this
--- Quote from: raym on October 14, 2011, 03:56:59 am ---... I just started watching a show and MC skipped forward the first 2 times as expected. About 20 mins in I backed up the video about 30 secs (NOT 10 mins) and MC did not skip the next ad. Stopping and restarting playback fixed it.
--- End quote ---
In this case, they skipped back not because of a wrong detection, but just to go back and see something. If MC had disabled skipping only until playback got past the point they skipped back from, it seems commercials would have been correctly skipped; since stopping and starting indicated the skip point was there/working. I'm guessing that upon skipping back MC disabled the next 'skip ahead' point instead? Maybe just a bug?
I think if MC could look back maybe 15 or 20 seconds to see if it's recently passed a 'end skip' marker when you press the back button. If not, you're just going back to see something again and skipping should not be affected at all. If there was recently a skip, take me back maybe 4 seconds (or 2) before where it 'skipped ahead' from, then disable that 'skip ahead' point, by disabling skipping until *after* that point. That would give me 20 seconds to notice that I missed part of the show, find the remote, maybe from another room, and hit back and go right back to wherever it skipped from and let me watch for whenever I might need to skip ahead.
BUT; that only works when it 'skipped ahead' too early. What if the 'end skip' was the problem? Then I need to go back maybe 20 seconds before that 'end skip' and see if that's commercial, or if I need back again to get back to the show.
I'm not sure how to distinguish which reason the back button was pressed. Perhaps a long-press to go back before the last 'skip ahead' point, and a regular back press will go back XX seconds before the last 'end skip' point, and 'skip ahead' points will be ignored until after where the back press happened?
I'm looking forward to giving it a go, once the build is released. I'll set some recordings to have some test files to work with.
I think I'll be happier working to fine-tune the comskip profile to better identify commercials, and not have to use the back button :)
Anyone know how to setup channel-specific profiles for comskip?
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version