INTERACT FORUM

More => Old Versions => Media Center 17 => Topic started by: Johnny B on April 28, 2012, 05:48:49 am

Title: Subtitle Timing (reversed logic)
Post by: Johnny B on April 28, 2012, 05:48:49 am
Is it only me who finds the Subtitle Timing logic to be reversed? I mean if I set for example +500ms I expect them to appear in T+500ms e.g. 0,5 second later however MC shows them 0,5 second earlier...
Title: Re: Subtitle Timing (reversed logic)
Post by: SamuelMaki on April 28, 2012, 08:25:39 am
Yeah, I have that too... I guess it is more like "video adjust" than "subtitle adjust" :) So, you put negative number-> video shows earlier (and subtitles later) and with positive number video shows later and subtitles earlier... If its not too much trouble, would developers fix this typo, so people who have used different player before are not confused ;) (replace the places of + and -)
Title: Re: Subtitle Timing (reversed logic)
Post by: Matt on April 28, 2012, 11:24:41 am
The subtitles normally show at some time.  Let's say 0:30.

If you say "add one second" (a positive number), then they show at 0:31 instead.

This means positive numbers show sooner, and negative numbers later.

I suppose if it was called "subtitle delay", it would make sense to work the other way.  But it's not a delay, it's an adjustment to the display time.

Am I thinking about this wrong?
Title: Re: Subtitle Timing (reversed logic)
Post by: Johnny B on April 28, 2012, 11:47:01 am
Now I'm confused.

As you say "adding 1 second" = positive number = 0:31 (originally 0:30) = LATER
However on the very next line you say "positive numbers = SOONER" ??

To me it's clear: original time of the subtitle is T, I want to see it later e.g. in T+n (where n is positive value like +1000ms) or earlier e.g. T-n (negative value like -1000ms)
Title: Re: Subtitle Timing (reversed logic)
Post by: Matt on April 28, 2012, 12:08:57 pm
I think I contradicted myself in the post above, or at least wasn't very clear.

It depends if you're adding the adjustment to the movie time or subtitle time.

Imagine a subtitle at 0:30 again.

Subtitle time: Add +1 to the 0:30 subtitle time, so show at 0:31 movie time: Positive = Later

Movie time: Add +1 to the movie time when picking a subtitle, so when the movie is at 0:29, show the subtitle from 0:30: Positive = Sooner

I guess both approaches seem reasonable to me.  I sometimes think about numbers weird, so am happy to follow popular opinion here.

Would changing the name from "Timing" to "Delay" clear anything up?
Title: Re: Subtitle Timing (reversed logic)
Post by: Johnny B on April 28, 2012, 12:15:25 pm
Subtitle time: Add +1 to the 0:30 subtitle time, so show at 0:31 movie time: Positive = Later

As the function is named "subtitle" timing then I believe this should be the right approach.

Would changing the name from "Timing" to "Delay" clear anything up?

Actually to me the most reasonable "fix" would be keeping the name and simply reverse the logic...
Title: Re: Subtitle Timing (reversed logic)
Post by: lepa on April 28, 2012, 01:18:19 pm
My take on the issue and how I think that most players/muxers approach the situation:

Call it a "subtitle delay"

The subtitles normally show at some time.  Let's say 0:30.
If you say "add one second" (a positive number), then they show at 0:31 instead.
This means positive numbers show subtitles later, and negative numbers sooner.
Title: Re: Subtitle Timing (reversed logic)
Post by: SamuelMaki on April 28, 2012, 01:21:56 pm
Seems that I wasn't as clear as I thought :) So, I did mean the naming is correct, only the + and - text are wrong at the menu ;) So if you just change them (+ comes -) the logic would be correct and everyone is happy :)
Title: Re: Subtitle Timing (reversed logic)
Post by: Johnny B on April 28, 2012, 01:23:45 pm
+1 (my original thought)
Title: Re: Subtitle Timing (reversed logic)
Post by: rick.ca on April 28, 2012, 05:14:03 pm
This is going to be my next excuse when I'm late for an appointment. ;D
Title: Re: Subtitle Timing (reversed logic)
Post by: vairulez on May 08, 2012, 10:21:07 am
I am still on 17.140.  Has the "logic" been fixed with newer builds?  I can't seem to find any mention of it in the logs
Title: Re: Subtitle Timing (reversed logic)
Post by: CountryBumkin on May 08, 2012, 10:56:36 am
You need to get off build .140 (it has problems) if you use Client syncing. And IMO, there are many other benefits to upgrading to .144 or later.
Title: Re: Subtitle Timing (reversed logic)
Post by: Matt on May 14, 2012, 01:02:27 pm
Next build:
Changed: Subtitle timing changed so that positive numbers make subtitles show later instead of earlier.
Title: Re: Subtitle Timing (reversed logic)
Post by: Johnny B on May 14, 2012, 02:01:14 pm
Thank you