INTERACT FORUM

More => Old Versions => JRiver Media Center 27 for Windows => Topic started by: sarcanon on April 06, 2021, 08:10:50 pm

Title: JRiver Fails to Import FLAC file But Won't Say Why
Post by: sarcanon on April 06, 2021, 08:10:50 pm

I've tried repeatedly to import an album of individual FLAC files, and JRiver consistently fails to import one of the 17 tracks.

The import summary says the following:

Quote

Library now has 224878 files. Search and update took 0:00.

Imported 0 new files.
Failed to import 1 file.

In-depth details:
Failed to import:
    P:\makdelart-split\Bach-Sacred Vocal Works-Bach 2000\B2000-ScrdVcl-11-14\CD13 - Psalm 51, Arias\Bach - Sacred Vocal Works (Bach2000 - Vol.6 CD13 - Psalm 51, Arias - Gunar Letzbor, Peter Schreier (17 - BWV0245c - Ach windet euch nicht so, geplagte Seelen-).flac

I've looked the log file, but there is nothing there indicating any kind of error or warning about this track.

The relevant portion of the log file is as follows:

Quote

...
0049048: 31260: Import: GetNewFiles: Searching: P:\makdelart-split\Bach-Sacred Vocal Works-Bach 2000\B2000-ScrdVcl-11-14\CD13 - Psalm 51, Arias\
0049050: 31260: Import: GetNewFiles: Importing (1 files)
0049050: 31260: Import: ImportNewFiles: Start
0049050: 31260: Import: ImportNewFiles: Adding: P:\makdelart-split\Bach-Sacred Vocal Works-Bach 2000\B2000-ScrdVcl-11-14\CD13 - Psalm 51, Arias\Bach - Sacred Vocal Works (Bach2000 - Vol.6 CD13 - Psalm 51, Arias - Gunar Letzbor, Peter Schreier (17 - BWV0245c - Ach windet euch nicht so, geplagte Seelen-).flac
0049050: 31260: Database: CMediaDatabase::AddFile: JRAnalyzer: 0x2757b179fc0
0049050: 31260: Database: CMediaDatabase::AddFile: Calling JRAnalyzer::Open
0049050: 31260: Import: JRAnalyzer::Open: Start
0049050: 31260: Import: JRAnalyzer::AddFile: Start
0049050: 31260: Import: JRAnalyzer::AddFile: Filename: P:\makdelart-split\Bach-Sacred Vocal Works-Bach 2000\B2000-ScrdVcl-11-14\CD13 - Psalm 51, Arias\Bach - Sacred Vocal Works (Bach2000 - Vol.6 CD13 - Psalm 51, Arias - Gunar Letzbor, Peter Schreier (17 - BWV0245c - Ach windet euch nicht so, geplagte Seelen-).flac
0049050: 31260: Import: JRAnalyzer::AddFile: Start
0049050: 31260: Import: JRAnalyzer::AddFile: Filename: P:\makdelart-split\Bach-Sacred Vocal Works-Bach 2000\B2000-ScrdVcl-11-14\CD13 - Psalm 51, Arias\Bach - Sacred Vocal Works (Bach2000 - Vol.6 CD13 - Psalm 51, Arias - Gunar Letzbor, Peter Schreier (17 - BWV0245c - Ach windet euch nicht so, geplagte Seelen-).flac
0049050: 31260: Import: JRAnalyzer::AddFileMJ: Start
0049050: 31260: General: CFileInfo::CFileInfo: Start
0049050: 31260: General: CFileInfo::CFileInfo: Finish (0 ms)
0049050: 31260: General: CFileInfo::~CFileInfo: Start
0049050: 31260: General: CFileInfo::Close: Start
0049050: 31260: General: CFileInfo::Close: Finish (0 ms)
0049050: 31260: General: CFileInfo::~CFileInfo: Finish (0 ms)
0049051: 31260: Import: JRAnalyzer::AddFileMJ: Finish (0 ms)
0049051: 31260: Import: JRAnalyzer::AddFile: Finish (0 ms)
0049051: 31260: Import: JRAnalyzer::AddFile: Finish (1 ms)
0049051: 31260: Import: JRAnalyzer::Open: Finish (1 ms)
0049051: 31260: Database: CMediaDatabase::AddFile: JRAnalyzer::Open returned
0049051: 31260: Import: ImportNewFiles:     Failed to analyze / add (changed recently)
0049051: 31260: Import: ImportNewFiles: Finish (1 ms)
0049051: 31260: Import: ImportNewFiles: Finish (1 ms)
0049051: 31260: Import: GetNewFiles: Finish (40 ms)
0049051: 31260: Import: GetMissingAndUpdateFiles: Start
0049051: 31260: Import: GetMissingAndUpdateFiles: Getting files
0049054: 31260: Import: GetMissingAndUpdateFiles: Sorting files
0049054: 31260: Import: GetMissingAndUpdateFiles: Looping 0 files
0049054: 31260: Import: GetMissingAndUpdateFiles: Finish (3 ms)
0049057: 31260: Import: Process: Finish (46 ms)
0049074: 31672: Import: Finish: Updating view schemes
0049092: 31672: Import: Finish: Showing summary
0049100: 31672: General: CMainUIWnd::Resize: Start
...

I've tried this repeatedly and get the same result each time. JRiver just doesn't like this one file, but gives no information about why it fails to import it.

Running latest version (27.0.79 64-bit) on Windows 10 Pro.

Any ideas about what I am doing wrong?

Thank you.

Title: Re: JRiver Fails to Import FLAC file But Won't Say Why
Post by: tij on April 07, 2021, 12:47:03 am

Under Tools > Options > General > Advanced, try checking the option to support long filenames.

Title: Re: JRiver Fails to Import FLAC file But Won't Say Why
Post by: sarcanon on April 07, 2021, 04:08:26 pm

Quote from: tij on April 07, 2021, 12:47:03 am

Under Tools > Options > General > Advanced, try checking the option to support long filenames.

Thank you for the suggestion, but that option was already enabled.

Title: Re: JRiver Fails to Import FLAC file But Won't Say Why
Post by: BigSpider on April 07, 2021, 04:11:55 pm

Does the file play if you right click it in windows explorer and select JRiver MC as the playing device?

Title: Re: JRiver Fails to Import FLAC file But Won't Say Why
Post by: Dawgincontrol on April 07, 2021, 08:52:48 pm

Try copying the file, make a duplicate and rename it.  Don't delete it, copy it.  See what that does.

Also, will it play in other prgrams?

Title: Re: JRiver Fails to Import FLAC file But Won't Say Why
Post by: sarcanon on April 09, 2021, 08:04:58 am

Quote from: BigSpider on April 07, 2021, 04:11:55 pm

Does the file play if you right click it in windows explorer and select JRiver MC as the playing device?

Quote from: Dawgincontrol on April 07, 2021, 08:52:48 pm

Try copying the file, make a duplicate and rename it.  Don't delete it, copy it.  See what that does.

Also, will it play in other prgrams?

So, it did play in JRiver when right-clicking in File Explorer. However, the same failed in VLC.

I did a little experimentation and renamed the file to something shorter, and lo and behold, JRiver successfully imported it. So, despite the longer file name support being enabled, it turns out JRiver still chokes on files with longer names. At least this one.

Quickly trying to guess at what the magic file length is, the full file path that JRiver objected to was 260 chars, while the shortened length that successfully imported was 214. So, I'm guessing it's going to be 255 (or 256) characters.

In any event, it would be much appreciated if JRiver could provide a meaningful error message in the results window when this sort of thing happens. Just failing without explanation is suboptimal. :-)

Title: Re: JRiver Fails to Import FLAC file But Won't Say Why
Post by: Matt on April 09, 2021, 08:16:22 am

Could you test an APE or MP3 with the same long filename?  I think our FLAC plugin might not be handling long paths nicely.

Let me know and thanks.

Title: Re: JRiver Fails to Import FLAC file But Won't Say Why
Post by: sarcanon on April 09, 2021, 09:07:55 am

Quote from: Matt on April 09, 2021, 08:16:22 am

Could you test an APE or MP3 with the same long filename?  I think our FLAC plugin might not be handling long paths nicely.

Let me know and thanks.

I'm not familiar with APE files. But I did rename an existing MP3 to have a 274-character file path and it was successfully imported.

Title: Re: JRiver Fails to Import FLAC file But Won't Say Why
Post by: Matt on April 09, 2021, 09:28:43 am

I think I just figured out the problem with the FLAC file you posted the filename to.

It was exactly the MAX_PATH length.  We do the special stuff if the name is longer, but it looks like we also need to do it if the name is equal.

Thanks for the help!

Title: Re: JRiver Fails to Import FLAC file But Won't Say Why
Post by: sarcanon on April 09, 2021, 05:32:48 pm

Quote from: Matt on April 09, 2021, 09:28:43 am

I think I just figured out the problem with the FLAC file you posted the filename to.

It was exactly the MAX_PATH length.  We do the special stuff if the name is longer, but it looks like we also need to do it if the name is equal.

Ah, off-by-one errors. You can't call yourself an experienced programmer until you've been tripped up by these at least once. :-)

Title: Re: JRiver Fails to Import FLAC file But Won't Say Why
Post by: dtc on April 09, 2021, 06:46:49 pm

Quote from: sarcanon on April 09, 2021, 05:32:48 pm

Ah, off-by-one errors. You can't call yourself an experienced programmer until you've been tripped up by these at least once. :-)

Always test the end cases, even if they seem extreme.

Title: Re: JRiver Fails to Import FLAC file But Won't Say Why
Post by: Matt on April 14, 2021, 01:54:27 pm

The MAX_PATH fix is here:
https://yabb.jriver.com/interact/index.php/topic,129192.0.html

Thanks :)