INTERACT FORUM
Windows => JRiver Media Center 33 for Windows => Topic started by: zybex on November 27, 2024, 04:12:07 am
-
Feature request for this usecase (https://yabb.jriver.com/interact/index.php/topic,140076.0.html) and many others:
1. Add "Before playback expression..." setting. Should execute when transitioning from STOPPED to PLAYING and when changing track, but not from PAUSED state. a SEEK should also not trigger it.
2. New Expression Language function:
ShellRun(command, args, flags, timeout)
command: shell command to execute (path to executable or .bat file)
args: optional arguments, e.g.: filekey() [width] [height]
flags: optional; 1=hidden, 2=KillOnTimeout, 4=CaptureStdout, 8= ... [flags values are added, 3=1+2]
timeout: optional, default=0; timeout in seconds to wait for command to finish. 0 means "do not wait", just start the process
With timeout>0:
- Mouse cursor can change to "busy" or some other custom icon/spinner while a command is executing, to provide some feedback to the user. Alternatively, show some on-screen indicator/notification somewhere.
- Pressing ESC or clicking the notification could immediately return from execution (forced timeout)
- On timeout, process should be killed only if "KillOnTimeout" flag is set.
Bonus: An "outputField" parameter could also be added - STDOUT would then be saved to this field. Alternatively, the CaptureStdout flag makes ShellRun() return the STDOUT output, allowing for things like setting a field to =ShellRun(c:\tools\getInfo.bat) in the Tag Editor.
-
would open interesting possibilities I'm sure
-
We'll start with this one:
NEW: Added a before playback expression.
Run commands would be possible, but they take a list of arguments. Would you separate them with a semi-colon?
Thanks.
-
Thank you Matt!
args could be a standard list if that makes it easier, yes.
-
Next build we'll try this too:
NEW: Added a ShellRun expression.
Thanks for the help :)
-
Some ShellRun() issues:
1.when called with blank 'args', it seems to default to some arg string used in a previous ExpressionLanguage function
test with replace(thisText,this,that) ShellRun(notepad) - notepad asks if you want to create 'this.txt'
2. function returns the 'command' arg value (ie, "cmd") instead of the STDOUT
test with ShellRun(cmd,//c;echo;testOutput) - returns "cmd", expected "testOutput"
3. calling with an invalid/unknown executable name results in a Windows popup (file not found)
test with ShellRun(someInvalidProg)
4. Flags are not implemented? There's always a flashing window for console programs even with Hidden=1
5. Timeout is not implemented? MC seems to always wait for process exit even with timeout=0 - it should return immediately with no output capture. Timeout>0 also does nothing.
Otherwise it seems to work :)
-
It just wasn't checking the number of arguments. That will be fixed next build.
I didn't add a timeout. You can block or not block.
I'll make it return the string from the call if you block.
Thanks for the help.
-
Tested build
47 49 - most issues above are fixed :)
ShellRun now works only with full path to the executable (ie, "c:\windows\system32\cmd.exe"). On build 48 it was working with just "cmd" or "python" which was easier. Can that be reverted?
Otherwise it seems to work! Can you please confirm the flags:
bit 1 = Wait for exit and return STDOUT
bit 2 = Create no window (hidden)
The args parameter is working both as a list and as a single string (on windows), ie, "//c;dir;c:\" works the same as "//c dir c:\". That's fine.
-
From the tooltip:
1: blocking, 2: hidden
It was using ShellExecuteEx but switched to CreateProcess. That doesn't work with something like "cmd". You need the full path now.
It can't return the result with ShellExecuteEx.
-
OK. Would it be possible to use SearchPathA (https://learn.microsoft.com/en-us/windows/win32/api/processenv/nf-processenv-searchpatha) ? Something like this:
string cmd = args[0];
if (!fileExists(cmd) && !cmd.contains('\') && !cmd.contains('/'))
{
cmd = Win32.SearchPathA(cmd);
if (!fileExists(cmd))
return "ShellRun: file not found";
}
// proceed with execution
...
-
Sure. Good idea.
Next build:
Changed: ShellRun searches the system for files so something like "cmd" will work.
Thanks.
-
Does it mean this implemented as a Windows specific function so not supported on Linux?
-
Just the path searching is Windows specific. I'm not certain if the run functions are implemented outside Windows.
-
Just the path searching is Windows specific. I'm not certain if the run functions are implemented outside Windows.
It should work on Mac and linux too. If not please report. The shell shouldn't need a path if you use it.
-
Pathless execution works fine on Windows :)
Can you please add a new flag?
4 = suppress output = always return an empty string, both in blocking and non-blocking mode
-
It only updates the output if flag 1 is set (so blocking mode). What does that hurt? I'm happy to add the option if you can help me understand. Thanks.
-
Hi Matt,
In non-blocking mode, it currently returns the executable name (arg 0). I'd prefer it to return nothing, or at most a success/fail flag (1 or 0).
In blocking mode, there are cases where the process prints out a huge dump to stdout which I really don't care about. I'm testing a script where I call ShellRun() twice to compute a field value, but I only want the output of the second call so I would like to suppress the first one:
=shellRun(app1.exe, args, 3)shellRun(app2.exe, args, 3)
I'm doing it with a workaround, but flag 4 would just be cleaner:
=if(shellRun(app1.exe, args, 3),,)shellRun(app2.exe, args, 3)
-
Sure. I'll add it to a build soon and please test. Thanks.