INTERACT FORUM
Windows => Third Party Plug-ins, Programs, and Skins => Topic started by: Doof on May 05, 2006, 11:31:02 am
-
New build is up. Version 1.2.2
Bug Fixes
- Fixed a bug where Lyrics Editor would prevent MC from starting if Playing Now was empty when MC tried to start
- Fixed a bug where you could Preview a track, then click Just Save Data, and the Return button would be disabled
- The refresh button is back!
Screenshot (http://doof.monadnockdesign.com/Plugins/Lyrics Editor/Screenshots/le122.jpg)
Download (http://doof.monadnockdesign.com/Plugins/Lyrics Editor/LyricsEditorSetup.exe)
Version 1.2
New Features
- Moved the Copy, Paste, Select All, and Clear commands into a standard toolbar at the top of the lyrics text box
- Added an "Undo" button that will return the lyrics to the state they were in before you began editing - this isn't as granular as the undo you'd see in a word processer - it will only get you back to where you started on that file in case you really screw up - once you've saved changes undo won't work
Bug Fixes
- Next (No Save) is no longer enabled when at the end of the file list - so it can't crash like it was before
New Features Since Version 0.9.5.5
- Added a "Next (No Save)" button that moves to the next file without saving changes
- Added tooltips to the file list that display information similar to MC's tooltips
- Playlist dropdown is now twice as large as before
- Playlist dropdown is now alphabetized (Playing Now is still always the first playlist listed)
- Refresh button now refreshes the list of playlists as well as their contents
- The "Purge Data" button now more intelligently reports how many files are going to have their LTEStatus field purged
- It now restores the playback state when you preview a file
- More buttons are disabled or enabled as appropriate
- Added "Purge Update Data" button that will purge the data stored in the LTEStatus field for all of the files currently in the file list
- Changed it so that it now only timestamps files when you make changes to their lyrics
- Columns should now remember their size and positions
- Options are now functional
- Added the ability to track what files have been viewed in Lyrics Editor - Check the "Save Viewed Status" box and click the "Create Database Field" button. LE will timestamp the file in a "LTEStatus" field
- The file list now has column headers that can be resized and rearranged
- Rearranged the interface a bit more
- You can now choose what colors you want to use for songs that: Have Lyrics, Don't Have Lyrics, Have Lyrics and have been viewed in LE, Don't Have Lyrics and have been viewed in LE
- File List colors now update as changes are made
- Plugin is now always active so you can jump out to another part of MC and come back without losing your place
- File list now shows files with lyrics in blue, and files without lyrics in red
- Rearranged the interface a bit in order to fit the Options
- Changed the "Select Source" text to "Get File List From" to better reflect what's actually going on - the file list is generated from this source, but they're not linked, so changes to the source won't be reflected in Lyrics Editor unless you hit the Refresh button
- Lyrics Editor now reports its build number to MCs Plugin Manager and Add/Remove Programs
Bug Fixes Since Version 0.9.5.5
- Status color is now updated when you just use the "Just Save Data" button
- Fixed a bug where it was possible to de-select any entries in the file list and then cause a crash when some of the buttons were pressed - it's still possible to de-select any entries in the file list, but now everything disables appropriately (appears to be a limitation of the list view control)
- You can no longer try to preview a file if there are no files to preview
- Fixed the bug that was occurring where you'd use the plugin, go to Playing Now and come back to the plugin and it would crash MC
-
Doofs on a roll! :)
-
Thanks to your Template. ;)
I'm mostly just trying to get familiar with the SDK and the C# language. I've got a couple of ideas for bigger things I'd like to try out. :)
-
Doof,
Can we play music in zone 1 playing now and have your plugin use zone 2 playing now so it won't interfere?
-
Good question. I'll look into doing that.
Ultimately, I think the answer will be to allow users to just browse a copy of their Media Library tree and select songs to edit directly. That's what I'd like to do. I just have to remember my recursion well enough to figure out how to traverse and populate a tree control to allow that.
-
I like it! That's pretty much what I was referring to and works well from what I could tell so far. Of course there are always suggestions. ;)
Ctrl+A doesn't work inside or inside MC's Lyric Editor either. Not sure if that's a shortcut that needs to be allowed or not in the code.
Suggestion: Make the Artist and Name fields at least selectable to copy to the clipboard. That way if there is no lyrics I could easily cut and paste to either a browser or tool to find them. It would also be nice to have a combination field that had the format that EvilLyrics uses which is Artist - Song. It wouldn't bother me if they were read-only text fields if that makes it easier.
Great job!
Jeff
-
@l@n's plugins allow us to specify a playlist to load. I find this approach a lot more comfortable than using the playing now list.
in the case of the caption plugin, it would allow us to listen to music while we worked away at our image captions.
at the moment, I'm more interested in the captionator, which looks like being a top-drawer addition to MC's image handling.
thanks for your work on it, hopefully I'll be able to give it a road-test over the weekend.
-
I like it! That's pretty much what I was referring to and works well from what I could tell so far. Of course there are always suggestions. ;)
Glad it's at least partly what you were looking for. :)
Ctrl+A doesn't work inside or inside MC's Lyric Editor either. Not sure if that's a shortcut that needs to be allowed or not in the code.
I'll take a look and see what I can figure out.
Suggestion: Make the Artist and Name fields at least selectable to copy to the clipboard. That way if there is no lyrics I could easily cut and paste to either a browser or tool to find them. It would also be nice to have a combination field that had the format that EvilLyrics uses which is Artist - Song. It wouldn't bother me if they were read-only text fields if that makes it easier.
I'm thinking there are several ways I could do this.
- Give you the ability to manually select and copy the artist and song title fields manually and seperately
- Present the information in the Artist - Name format and make that selectable
- Have a button in the plugin that automatically copies the Artist - Name text to the clipboard
- Have a button in the plugin that spawns a Google search of Artist+Name+lyrics
The last one the list would be the most helpful to me. Not sure if other people work the way I do, though.
-
@l@n's plugins allow us to specify a playlist to load. I find this approach a lot more comfortable than using the playing now list.
Yeah, me too. And it's the way I ultimately want to get both plugins working. I just have to figure out how. :P Maybe @l@n could lend me a hand? Although I was looking at the old VB version of the BusyBox plugin and noticed they're doing the same kind of tree replication I want to do, so it might not be too hard to convert that over to C#. Although I'm assuming that Mr Chriz's C# implementation of BusyBox must have already done that, so if I could get my hands on that... *hinthint*
in the case of the caption plugin, it would allow us to listen to music while we worked away at our image captions.
Definitely.
at the moment, I'm more interested in the captionator, which looks like being a top-drawer addition to MC's image handling.
thanks for your work on it, hopefully I'll be able to give it a road-test over the weekend.
Yeah, after I got done organizing all of my pictures, I started thinking how nice it would be to be able assign captions to them that could be seen during playback in Theater View. But the thought of using MC's built in tag editor for such a purpose really didn't appeal to me. I'm glad I'm not the only one who will find it useful.
-
Have a button in the plugin that spawns a Google search of Artist+Name+lyrics
A Google search option would be my choice! Even better if it launched in the user's default browser instead of IE, if that's possible.
-
Busybox C# Uploaded.
I'm afraid I'm really quite short of time at the present.
(Wonder where it all goes sometimes...)
Life keeps wanting to get in the way.
I've no idea whether it's currently in a working state or not.
You'll have to play.
But for the most part the codes there.
-
That's ok. Your contributions to this forum have been phenomenal. Take a break! :)
-
Well, I've got the Google search running. Not sure if it'll use the default browser or not. I suspect it will because all I'm doing is spawning a URL. At that point, I think Windows decides what to do with it.
I can't seem to get Ctrl-A to work for selecting all of the text. The same code that works in a standalone Windows app doesn't work in the plugin, so I suspect MC isn't passing it through or something.
The updated version can be downloaded here (http://doof.monadnockdesign.com/Plugins/Lyrics Editor/LyricsEditorSetup.exe).
-
It opened a new tab in Firefox for me… awesome!
Here's an idea… take it or leave it. Maybe put a play and stop button into the plugin, so you can check the accuracy of the lyrics, or in my case, I like to put "Instrumental" into the lyrics tags once I've verified that the song has no lyrics.
Any possibility you could make the plugin open in a free-floating, re-sizable window?
-
Question: Will I lose everything if I don't hit "Save" after each edit?
-
Question: Will I lose everything if I don't hit "Save" after each edit?
Nope, it saves automatically when you click Previous or Next. The Save button is just there in case you want to exit out of the plugin without changing tracks. I'm kind of wrestling with how it should behave in this regard. Any suggestions?
-
Hmmm… maybe make the button label as "Save & Exit" instead of just "Save."
-
I could do that. But there's no way to really Exit a plugin, so that would be kind of a misnomer.
-
How about "Save and Stop"?
I like the Google search. In the past I have found that sometimes I need to surround the artist and/or name with double quotes so that the exact string will be found for a more specific search instead of the words being anywhere on the page. Any chance of doing that?
Regarding these:
- Give you the ability to manually select and copy the artist and song title fields manually and seperately
- Present the information in the Artist - Name format and make that selectable
- Have a button in the plugin that automatically copies the Artist - Name text to the clipboard
You already have number one listed on the page but they are not selectable. Making selectable so a Ctrl+C could be done would solve that.
I would ignore the second one and since you now have a Google button, the third one would be really nice.
-
Here's an idea… take it or leave it. Maybe put a play and stop button into the plugin, so you can check the accuracy of the lyrics, or in my case, I like to put "Instrumental" into the lyrics tags once I've verified that the song has no lyrics.
Any possibility you could make the plugin open in a free-floating, re-sizable window?
If you want to do this, you can do it with MC itself. Use a Track Info that displays the lyrics. I use "All I Need" that can be found in this forum. Select the first song and press Alt+Enter to display the tag editor and display the Lyrics field. Then just play, verify the lyrics, and if editing is necessary, click the Edit button in the Lyrics field in the tag editor. Everything okay, just hit the Next button to play the next song.
-
Use a Track Info that displays the lyrics. I use "All I Need" that can be found in this forum. Select the first song and press Alt+Enter to display the tag editor and display the Lyrics field
dcwebman… I made the "All I need" track info template. Glad you like it. ;D But it is still a lot of clicks to get to the lyrics edit screen, and the lyrics field can be hard to find in the tag info list if you display a lot of fields. But my main reason for wanting it is because I tend to add lyrics in batches, which is what this plugin is perfect for. If I suspect a song is fully instrumental, I like to just sample a few points in the song to make sure before marking it as such.
In the past I have found that sometimes I need to surround the artist and/or name with double quotes so that the exact string will be found for a more specific search instead of the words being anywhere on the page.
I've been finding I get better results not using quotes for exact match. A lot of times I'll put extra stuff at the end of the song title like (Live) or (Remix), etc. When you put the title in quotes it often won't come up with any lyric results if you have anything extra like that, but without quotes you usually still get the lyrics on the first page of results no matter what. For the rare instances when it doesn't come up with lyrics, you can still add the quotes in the browser. I suspect the frequency of not finding lyrics on the first page will be higher with quotes than without.
-
@l@n's plugins allow us to specify a playlist to load. I find this approach a lot more comfortable than using the playing now list.
Yeah, me too. And it's the way I ultimately want to get both plugins working. I just have to figure out how. Maybe @l@n could lend me a hand?
Doof, here is an example of using a user selected playlist or Playing Now. Warning -- I cut and pasted this code together so there are probably some typos in it.
I hope this helps... @l@n
#region Private Members
private MediaJukebox.MJPlaylistsAutomation m_MJPlaylists = null;
private MediaJukebox.MJCurPlaylistAutomation m_MJCurPlaylist = null;
private MediaJukebox.MJFilesAutomation m_MJPlaylistFiles = null;
#endregion
#region COM initialization
public void Init(MediaJukebox.MJAutomation mj)
{
m_MJPlaylists = m_MJ.GetPlaylists();
Debug.Assert(m_MJPlaylists != null, "MediaJukebox.MJAutomation.GetPlaylists() returned null");
LoadPlaylists();
//present the user with a list of playlists with Playing Now
//as the first entry int the list (idx = 0).
int idx = 0; //Playing Now
if (idx == 0)
{
m_MJCurPlaylist = mj.GetCurPlaylist();
Debug.Assert(m_MJCurPlaylist != null, "MediaJukebox.MJAutomation.GetCurPlaylist() returned null");
m_MJPlaylistFiles = null;
}
else
{
MediaJukebox.MJPlaylistAutomation playlist = m_MJPlaylists.GetPlaylist(idx);
m_MJPlaylistFiles = playlist.GetFiles();
Debug.Assert(m_MJPlaylistFiles != null, "MediaJukebox.MJPlaylistAutomation.GetFiles() returned null");
m_MJCurPlaylist = null;
}
int numFiles = GetNumFiles();
for (int i = 0; i < numFiles; i++)
{
MediaJukebox.MJFileAutomation mjFile = GetFile(i);
if (mjFile.Lyric.Length > 0)
MessageBox.Show("Song #" + i + " has a lyric!!!");
}
}
#endregion
#region Private Methods
/// <summary>
/// Load cboPlaylist with a list of playlists
/// </summary>
private void LoadPlaylists()
{
int plCnt = m_MJPlaylists.GetNumberPlaylists();
cboPlaylist.BeginUpdate();
cboPlaylist.Items.Add("Playing Now");
m_playlists["Playing Now"] = 0;
for (int i = 0; i < plCnt; i++)
{
MediaJukebox.MJPlaylistAutomation playlist = m_MJPlaylists.GetPlaylist(i);
cboPlaylist.Items.Add(playlist.Name);
m_playlists[playlist.Name] = i;
}
cboPlaylist.EndUpdate();
}
/// <summary>
/// Get the number of files in the selected playlist.
/// </summary>
/// <returns></returns>
private int GetNumFiles()
{
int numFilesInPlaylist;
if (m_MJCurPlaylist != null)
numFilesInPlaylist = m_MJCurPlaylist.GetNumberFiles();
else
numFilesInPlaylist = m_MJPlaylistFiles.GetNumberFiles();
return numFilesInPlaylist;
}
/// <summary>
/// Gets a MJFileAutomation interface for a file number.
/// </summary>
/// <param name="?"></param>
/// <returns></returns>
private MediaJukebox.MJFileAutomation GetFile(int fileNum)
{
MediaJukebox.MJFileAutomation mjFile;
//are we using Playing Now or another user selected playlist?
if (m_MJCurPlaylist != null)
mjFile = m_MJCurPlaylist.GetFile(fileNum);
else
mjFile = m_MJPlaylistFiles.GetFile(fileNum);
return mjFile;
}
#endregion
-
One thing that would be useful is the ability to edit the song title at the same time. I'm finding some typos and misspellings as I search for lyrics.
-
Ok, new version.
I've added a bunch of stuff...
- The Artist, Album, and Name labels are now buttons, so you can easily copy any of those fields to the clipboard
- A button that copies [Artist] - [Name] to the clipboard
- Buttons that copy text from the lyrics box, paste text to the lyrics box, and select all text in the lyrics box
- Hopefully clearer text about what the Next, Previous, and Save buttons do
I decided not to incorporate the other playback controls because ultimately, you can use MC's standard playback controls to do that.
So give it a try and let me know what you think. The link is here (http://doof.monadnockdesign.com/Plugins/Lyrics Editor/LyricsEditorSetup.exe).
-
Very nice,
With all of the new buttons in the latest version, is there still a reason to automatically select all when you go to next or previous track? There is now a button to select all. It is more readable if all of the text is not selected.
Anyway, great plug-in.
Randy
-
Ok, new build.
- Got rid of the SelectAll on track change
- Re-worked the buttons a little bit to allow in-place editing of Artist, Album, and Name
Download it here (http://doof.monadnockdesign.com/Plugins/Lyrics Editor/LyricsEditorSetup.exe).
Thanks for all the feedback!
Eventually, I want to work in the ability to just choose a playlist to edit instead of always using Playing Now. And I'd like to rework it a bit so it'll resize itself based on the size of the MC window. But keep the suggestions coming!
-
I just downloaded & installed the new version.
It still selects all automaticaly when I push the next or previous button to change tracks.
Randy
-
Doof, looking good!!!
A little problem. I pressed the Copy button without selecting any of the lyric text and it crashed.
--@l@n
-
I just downloaded & installed the new version.
It still selects all automaticaly when I push the next or previous button to change tracks.
Randy
Yeah, I was just uploading a new version because I noticed it was still doing that. Try it again. It shouldn't be doing that anymore.
-
Doof, looking good!!!
A little problem. I pressed the Copy button without selecting any of the lyric text and it crashed.
--@l@n
Whoops! Guess I better build in some exception handling, huh? :P
-
Doof, looking good!!!
A little problem. I pressed the Copy button without selecting any of the lyric text and it crashed.
--@l@n
Ok, I took care of that little problem. The Copy button should now always be disabled unless there's something in the lyrics box selected. I'm wrestling with the idea of if the Copy button should handle selected text anywhere in the plugin, like in the Artist, Album or Name boxes. Right now I'm thinking it doesn't make sense, since there's buttons right there that will copy them much easier.
Latest build (http://doof.monadnockdesign.com/Plugins/Lyrics Editor/LyricsEditorSetup.exe) fixes that particular crash.
-
I tried the latest one.
Looks good to me.
Randy
-
The latest version is really good. You've done a fantastic job in just a day!
Thanks,
Jeff
-
Found a little problem. Tried to use the Google Search for the following file (pasted from the big copy button :)):
Blood, Sweat & Tears - You Made Me So Very Happy
Ended up getting just
Blood, Sweat
in the Google search.
Oh, one minor suggestion. When at the beginning of the playing now list, disable the Previous button and when at the end, disable the Next button.
-
Wow! You've done a lot while I was sleeping. I'm really enjoying this plugin.
-
Doof
Now that you've made so much progress, I'd like to suggest a way to allow playing the track while editing it using your plug-in.
I think a simple solution would be to not disable play when you start the plugin. The track playing would then be the track you are viewing. If you push the next or prev button in the plugin change the track accordingly.
It is very helpful to hear the song while you are editing the lyrics. Even if there are restictions in how it works, it would be a nice feature.
Randy
-
Ok, new build up.
- Fixed the bug where "&" wasn't being sent with the rest of the Google query - although I'm still not happy with this whole thing because special characters aren't being handled correctly and I haven't had much luck figuring out how to handle these.
- Set it so the Next and Previous buttons disable if you can't move to the next or previous tracks - if Continuous mode is on then they will always be enabled
- The layout should now resize itself to match the window size. More or less. :P
Download (http://doof.monadnockdesign.com/Plugins/Lyrics Editor/LyricsEditorSetup.exe)
-
Doof
Now that you've made so much progress, I'd like to suggest a way to allow playing the track while editing it using your plug-in.
I think a simple solution would be to not disable play when you start the plugin. The track playing would then be the track you are viewing. If you push the next or prev button in the plugin change the track accordingly.
It is very helpful to hear the song while you are editing the lyrics. Even if there are restictions in how it works, it would be a nice feature.
Randy
I'm still trying to decide how to implement this. On the one hand, it would be nice if you could listen to the songs, see the lyrics pop up and make quick edits while listening to the song. On the other, it would be a real pain if you were in the middle of making changes and the plugin switched songs on you. I'm sure a checkbox to either follow Playing Now or stay independent of it could work. But it would also be nice to work on one set of songs while listening to a completely different set. But then what happens if you want to hear the song you're working on?
I'm not sure there's a way to handle all the eventualities.
I wonder how hard it would be to be able to choose between a playlist or Playing Now, where if the user chose a playlist, then you can listen to a completely different set of songs than the ones you're working on, and if you chose Playing Now, then it works with those, and gives you the option to either follow along or stay independent...
I'll play around with a few things and see what it looks like. If you have any suggestions, either about this or other stuff, have at it! :)
But right now I need to shower and scrounge up some food. I already skipped sleeping last night. :P
-
Doof,
I like your idea of using a playlist. If you want to hear the song, you can click on the playlist selection & it will play, but that is independent of how you are managing the changes to the lyrics.
If you drive it from playing now, you could always loop the track so you don't have it change tracks in the middle of an edit.
Anyway, the good thing about software (or the bad thing) is that it is never done until people stop using it.
Randy
-
The layout should now resize itself to match the window size. More or less.
Very nice on my 20" LCD. :) I like how the paste button expands so you don't need to aim very well.
Edit to add: It seems the "paste" and "Select All" buttons have stopped working for me in this last build. Anyone else?
-
Very nice on my 20" LCD. :) I like how the paste button expands so you don't need to aim very well.
Edit to add: It seems the "paste" and "Select All" buttons have stopped working for me in this last build. Anyone else?
Whoops, you're right. When I moved those buttons into the lyrics groupbox, it broke the connection to the event handlers. It happened when I moved the navigation and clipboard buttons into their respective groupboxes, too. You'd think I'd learn. :P
Redownload and try again. It should be fixed now.
-
Doing a little experimenting..
What do you guys think of this? Right direction?
Screenshot (http://doof.monadnockdesign.com/Plugins/Lyrics Editor/Screenshots/less1.jpg)
-
Just an idea (Of which there appear to be many!),
but why stop at Lyrics? You could have a drop down
to retrieve any field, and rename the plugin
The ALL MIGHTY Tag Editor =)
-
What do you guys think of this? Right direction?
The problem with using a list box you may be limited to 32,7xx+ files
-
The problem with using a list box you may be limited to 32,7xx+ files
Just tested a listbox with 100,000 entries and it's ok with .NET 2.0 /XP Pro.
Of course if you've got that many entries in a single listbox thats probably the least
of your worries!
-
i am not sure about .net
With VB 6.0 you can have 100,000+ items in it thats not the problem, but if you do a x=list1.listcount the control will return -1
so it will not return the correct count above 32,7xx
-
I like the listbox of songs. That gives an idea of what's coming up or what was back. Sorry I started a rollercoaster here. ;D
-
i am not sure about .net
With VB 6.0 you can have 100,000+ items in it thats not the problem, but if you do a x=list1.listcount the control will return -1
so it will not return the correct count above 32,7xx
I just tested it with 1,000,000 entries. It reported the count correctly, and all the items are reporting their index correctly. Looks like it was a limitation that was lifted in .Net
-
I just tested it with 1,000,000 entries. It reported the count correctly, and all the items are reporting their index correctly. Looks like it was a limitation that was lifted in .Net
I am not really a .net fan, but am happy they fixed that.
-
I am not really a .net fan, but am happy they fixed that.
Spend some more time with it :)
I can understand why some VB 6 people got annoyed with it,
and why the VB side got nicknamed VB.NOT but after you've
played for a while, the flexability it offers is just fantastic.
Plus all the advantages of full OO support. Really rich
class librarys etc.
I think it is one of the best things Microsoft have done in a long time.
It leaves Java somewhat lacking IMO.
Very quick learning.
The biggest problem I have with .NET is I'll spend a day or
two implementing something that Microsoft have already done for you
and placed in an obvious place, and I didn't think to look!
I intend to produce a VB.NET template to go along side the C# one.
Shouldn't take long since the documentation should be more or less Identical.
-
Ok, new build up. :)
WARNING
Be very careful with this one. While it seems to be behaving correctly, I did have some problems where some files were getting updated with the information from other files. I'm 99.999% sure I have it fixed, but be forewarned. ;)
New Features:
- Added the ability to select a playlist to work on as well as Playing Now
- Added a list of files that you're currently working on
- You can now listen to songs in Playing Now while working on songs in Playing Now - it doesn't automatically change tracks when Playing Now does, though (yet)
- You can select files in the file list to change files - keep in mind that changing the selection, whether it's using the Next or Previous buttons or the file list automatically updates the file information (lyrics, artist, album, and name)
- Added a "Clear" button that will clear the contents of the lyrics box (in case you find the lyrics are completely the wrong ones)
- Swapped the locations of the Next and Previous buttons to better match up with the visual representation of the file list
Download (http://doof.monadnockdesign.com/Plugins/Lyrics Editor/LyricsEditorSetup.exe)
-
Doof, you are Farm Animal brilliant. I'm just trying your plugin out for the first time, so I'm going slow and letting somebody else erase all their data first, if something's going to erase all the data. But so far, this is spectacular work. Thank you, thank you.
Crazy / Ungrateful / Ignorant question here: Does the MC lyrics system allow for changing format, say font or type size, etc? These kinds of tools would be cool, if that were possible.
Question: I make a simple change for the sake of easily spotting the change, namely inserting four rows of space between a line. I skip down my playlist WITHOUT saving, and yet when I come back the test change is still there. Maybe a clear RESTORE button down among PREVIOUS, NEXT, & JUST SAVE DATA.
Also, I'm not using PREVIOUS and NEXT for anything, your column setup is so user-friendly. Do these buttons do anything else, along the lines of saving data or discarding it? "JUST SAVE DATA" is clear enough even for me.
Clearly, Doof, some animals were created equaller than others! Great work!
-
You know, ChriZ is right: this is a tag editor, too (I believe he was the one who said this). You could expand the button column on the right, allow for dragging adjustments to all three columns, and just populate the right side with all available tags.
-
Doof, you are Farm Animal brilliant. I'm just trying your plugin out for the first time, so I'm going slow and letting somebody else erase all their data first, if something's going to erase all the data. But so far, this is spectacular work. Thank you, thank you.
Glad you're enjoying it. :)
Crazy / Ungrateful / Ignorant question here: Does the MC lyrics system allow for changing format, say font or type size, etc? These kinds of tools would be cool, if that were possible.
MC doesn't support formatting the tag data, but at one point (a couple of years ago), I played around with embedding html tags to the lyrics so that when they're displayed in a Track Info Template, you could have it formatted however you lked.
Question: I make a simple change for the sake of easily spotting the change, namely inserting four rows of space between a line. I skip down my playlist WITHOUT saving, and yet when I come back the test change is still there.
This is by design. It's designed to make it as quick and easy as possible to make changes. Just make the change you want, then move on to the next file. Think of it as an inline Lyrics editor, much like how MC can do inline edits of the simpler tags. The "Just Save Data" button is there for when you want to save the changes without moving to the next track. it's really only needed for when you make a change and then exit the plugin, mainly because I can't figure out what events MC triggers when you leave the plugin to make it save changes then.
I could probably add an option to only save if the Save button is pressed. Or if a lot of people would rather it didn't save changes unless they specifically told it to, I could make that change.
Maybe a clear RESTORE button down among PREVIOUS, NEXT, & JUST SAVE DATA.
I wrestled with the idea of an Undo/Redo system, but since it saves changes when it changes tracks, I wasn't sure how this kind of functionality should work.
Also, I'm not using PREVIOUS and NEXT for anything, your column setup is so user-friendly. Do these buttons do anything else, along the lines of saving data or discarding it? "JUST SAVE DATA" is clear enough even for me.
Currently all they do is save the changes you made to the current file and move on the next or previous file. Once I get around to some of the other things I'd like to add, they may do more. If not, I could probably remove them without losing anything.
Clearly, Doof, some animals were created equaller than others! Great work!
Thanks! :)
You know, ChriZ is right: this is a tag editor, too (I believe he was the one who said this). You could expand the button column on the right, allow for dragging adjustments to all three columns, and just populate the right side with all available tags.
I thought about this, and decided that MC's built-in tag editor is much nicer and much more powerful for the vast majority of the tags. What I think I might do, though, is expand this plugin to handle Bios and Review as well; basically the fields that aren't so easily editable by MC's built-in tag editor.
-
Alright, since I'm offering up numbskull-oriented change suggestions, here's another:
"Select Source" is perfect. I have PN in AW showing, and the "File List" next to it. Very clear. However, if I reorder PN, "File List" is out of order. I can go back to "Select Source" and refresh by going away and coming back, but what about a "Refresh from Source" button? Hmmm?
-
Just posted another build that fixes a bug where it would crash if you selected an empty playlist (or if Playing Now was empty).
Download (http://doof.monadnockdesign.com/Plugins/Lyrics Editor/LyricsEditorSetup.exe)
-
Alright, since I'm offering up numbskull-oriented change suggestions, here's another:
"Select Source" is perfect. I have PN in AW showing, and the "File List" next to it. Very clear. However, if I reorder PN, "File List" is out of order. I can go back to "Select Source" and refresh by going away and coming back, but what about a "Refresh from Source" button? Hmmm?
I'm sure I could do that. This is the kind of thing that would could be automatic if MC would broadcast events when things like playlists updated or playback status changed.
-
Trying the latest built, I just pasted in the first lyrics, hit next and got a .NET Framework error:
See the end of this message for details on invoking
just-in-time (JIT) debugging instead of this dialog box.
************** Exception Text **************
System.NullReferenceException: Object reference not set to an instance of an object.
at MC_Lyrics_Editor.MainInterface.updateFile(MJFileAutomation& File) in E:\Users\Matt\My Documents\Visual Studio 2005\Projects\MC_Lyrics_Editor\MC_Lyrics_Editor_Solution\MC_Lyrics_Editor_Project\MainInterface.cs:line 354
at MC_Lyrics_Editor.MainInterface.btnNext_Click(Object sender, EventArgs e) in E:\Users\Matt\My Documents\Visual Studio 2005\Projects\MC_Lyrics_Editor\MC_Lyrics_Editor_Solution\MC_Lyrics_Editor_Project\MainInterface.cs:line 334
at System.Windows.Forms.Control.OnClick(EventArgs e)
at System.Windows.Forms.Button.OnClick(EventArgs e)
at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.ButtonBase.WndProc(Message& m)
at System.Windows.Forms.Button.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
************** Loaded Assemblies **************
mscorlib
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.42 (RTM.050727-4200)
CodeBase: file:///C:/WINDOWS/Microsoft.NET/Framework/v2.0.50727/mscorlib.dll
----------------------------------------
MC_Lyrics_Editor
Assembly Version: 1.0.2318.28476
Win32 Version: 1.0.0.0
CodeBase: file:///g:/Program%20Files/J%20River/Media%20Center%2011/Plugins/Lyrics%20Editor/MC_Lyrics_Editor.DLL
----------------------------------------
System.Windows.Forms
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.42 (RTM.050727-4200)
CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Windows.Forms/2.0.0.0__b77a5c561934e089/System.Windows.Forms.dll
----------------------------------------
System
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.42 (RTM.050727-4200)
CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System/2.0.0.0__b77a5c561934e089/System.dll
----------------------------------------
System.Drawing
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.42 (RTM.050727-4200)
CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Drawing/2.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll
----------------------------------------
Accessibility
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.42 (RTM.050727-4200)
CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/Accessibility/2.0.0.0__b03f5f7f11d50a3a/Accessibility.dll
----------------------------------------
MediaJukebox
Assembly Version: 1.0.0.0
Win32 Version: 1.0.0.0
CodeBase: file:///g:/Program%20Files/J%20River/Media%20Center%2011/Plugins/Lyrics%20Editor/MediaJukebox.DLL
----------------------------------------
************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.
For example:
<configuration>
<system.windows.forms jitDebugging="true" />
</configuration>
When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box.
-
Trying the latest built, I just pasted in the first lyrics, hit next and got a .NET Framework error:
Hmm... that was a weird one. I think I got it, though. Give this build a try and see if it comes back...
Also... I added a refresh button to handle those cases where you manage to change the playlist you're working on without actually leaving the plugin (like through the Action Window).
Download (http://doof.monadnockdesign.com/Plugins/Lyrics Editor/LyricsEditorSetup.exe)
-
Doof, you are the Dawg! Even I can find my way to a nice green refresh button. Thanks!
Free-association time, Tiger. So, this is a Lyrics Editor, but how do you know if you've edited the lyrics? I mean, you've got 10,000, 20,000 tracks, maybe you lose your place. What about a custom field that would time-stamp the saves? Sparta, on the other side of the equation, could use this info to judge the accuracy of the lyrics in his db, since I'm finding a lot of humming and "She may be wooley" in the lyrics I've opened so far.
Just a thought. My main thought is, this is totally cool--do the Russians have anything like this.
-
I really need to get away from this computer...
New build...
New Feature
- You can now preview the selected file by clicking the "Preview" button and MC will start playing it. Clicking the "Return" button will return you back to where you left off.
Enjoy!
Download (http://doof.monadnockdesign.com/Plugins/Lyrics Editor/LyricsEditorSetup.exe)
-
Doof--
This is BIZARRE! You've completely taken over PN in the AW! You must be fooling with alternate zones or alternate dimensions, cowhound! It's really cool but, I mean, does jriver know about this?
Works as advertized, I can cut in and out of songs at will, edit their doggone lyrics and see PN restored when viewed in split views, but AW PN is a goner, it's a slave to your plugin. If I want to restore it, I have to close out your lyrics, shut PN and then open it again. No problem, but while you're at it, why not just make a new PN plugin?
I mean, when I view PN in split views, and then perform a search on an audio view, all views not occupied by an interface plugin get searched also. This means once I've found the tracks I want in the audio view, I also have to restore PN in the other view before I can successfully drag selected tracks to it. But if it was an interface plugin, which gave me the same editable fields I had with PN when it was an audio view, that wouldn't happen.
Listen, it took you three days to do this plugin and it's pretty much done. I think you're ready for a new challenge, you monster!
-
Doof--
This is BIZARRE! You've completely taken over PN in the AW! You must be fooling with alternate zones or alternate dimensions, cowhound! It's really cool but, I mean, does jriver know about this?
Works as advertized, I can cut in and out of songs at will, edit their doggone lyrics and see PN restored when viewed in split views, but AW PN is a goner, it's a slave to your plugin. If I want to restore it, I have to close out your lyrics, shut PN and then open it again. No problem, but while you're at it, why not just make a new PN plugin?
I'm not sure I understand. I've got 2 Views showing, 1 showing PN, the other showing Lyrics Editor, and the AW is set to show PN. If I preview a track, PN in the split view and in the AW update to show the file you're previewing. When I click "Return" PN is restored to what it was before and both the PN in the split view and the AW reflect this. Is that not happening for you?
I mean, when I view PN in split views, and then perform a search on an audio view, all views not occupied by an interface plugin get searched also. This means once I've found the tracks I want in the audio view, I also have to restore PN in the other view before I can successfully drag selected tracks to it. But if it was an interface plugin, which gave me the same editable fields I had with PN when it was an audio view, that wouldn't happen.
I also don't quite understand this, either. Can you go into more detail about what you're seeing, what you expect to happen, and the series of steps you're using so I can try and recreate it?
Listen, it took you three days to do this plugin and it's pretty much done. I think you're ready for a new challenge, you monster!
Don't worry. I have a lot of ideas. :)
-
From the latest build:
- The drop down for finding Playing Now or other playlists needs to have a specified height limit put on it. I guess I have too many playlists because it just disappeared off the bottom of the screen and I couldn't scroll to those.
- Minor suggestion. Swap the Album and Name buttons/fields since this is the order usually used to find the lyrics to a song.
- I had one song in Playing now and went to Preview it. While it was playing, I played around typing in the editor and then hit the Clear button since it didn't have real lyrics. I then clicked the Playing Now button from the tree without saving to see if the Lyrics field (I have a customized field added saying Yes or No) had been set to No. It hadn't as expected but then I got a popup error:
Unspecified Error (Exception from HRESULT: 0x80004005 (E_FAIL))
This caused it to close Media Center (version 183). BTW, this got the Incomplete Shutdown Detected message when MC started again.
- May be related to the above one. Opened up MC again and it had the one song in Playing Now with the lyrics. Went to Lyrics Editor plugin and hit Clear, Just Save Data, and then Playing Now in the tree. My Lyrics field was No which was good. Clicked Lyrics Editor again and MC just closed. Loaded up more songs and switching between Playing Now and Lyrics Editor, eventually closes MC when clicking on Lyrics Editor. Might be some conflict with another plug-in but before I debug further just wanted to mention it.
- You've been putting out a lot of updates which is great but would it be time to put a version number somewhere so that we make sure we have the latest? You might want to update your first post listing the latest version just so we don't have to download again to make sure. In the Plug-in manager it always says 0.0.0.1.
-
From the latest build:
- The drop down for finding Playing Now or other playlists needs to have a specified height limit put on it. I guess I have too many playlists because it just disappeared off the bottom of the screen and I couldn't scroll to those.
I'll see what I can do. :)
- Minor suggestion. Swap the Album and Name buttons/fields since this is the order usually used to find the lyrics to a song.
Out of curiosity, how are you using these? I've had such good luck just hitting the Google Search button that I never use the others.
- I had one song in Playing now and went to Preview it. While it was playing, I played around typing in the editor and then hit the Clear button since it didn't have real lyrics. I then clicked the Playing Now button from the tree without saving to see if the Lyrics field (I have a customized field added saying Yes or No) had been set to No. It hadn't as expected but then I got a popup error:
Unspecified Error (Exception from HRESULT: 0x80004005 (E_FAIL))
This caused it to close Media Center (version 183). BTW, this got the Incomplete Shutdown Detected message when MC started again.
I've had that pop up a few times, but I can never seem to figure out how to reproduce it. It's not a .Net message, it's coming from MC directly. It's a little different for me, though, because it's never actually crashed MC. So when I got it, I would just click on some other plugin and then back on Lyrics Editor and it starts up fine. So it's been a real person to track down. If you (or anybody else) can find a rock-solid way of reproducing this one I'd be really grateful. :)
- May be related to the above one. Opened up MC again and it had the one song in Playing Now with the lyrics. Went to Lyrics Editor plugin and hit Clear, Just Save Data, and then Playing Now in the tree. My Lyrics field was No which was good. Clicked Lyrics Editor again and MC just closed. Loaded up more songs and switching between Playing Now and Lyrics Editor, eventually closes MC when clicking on Lyrics Editor. Might be some conflict with another plug-in but before I debug further just wanted to mention it.
Sounds like it is related to the above. When my plugin starts, the first thing it does is populate the dropdown with all of the playlists, then it selects Playing Now as the starting point. I wonder if just not having anything pre-selected would make this go away. I could try that for a build or two and see if it helps.
- You've been putting out a lot of updates which is great but would it be time to put a version number somewhere so that we make sure we have the latest? You might want to update your first post listing the latest version just so we don't have to download again to make sure. In the Plug-in manager it always says 0.0.0.1.
Yeah, I'm really bad about that. I'll get better. I promise. :P
-
D--
I don't see the AW PN thing today after a restart, imagine that! What I was seeing before was that the track listing populating AW PN would disappear when you previewed a different track, and not return. AW PN would shrink to 1 track in height and stay there, never returning to full height.
TODAY, I can confirm what DC says about AW PN going to full height, even though it only hold one track. However, it does reurn to normal when you hit return.
My shameless request for a PN lugin was based on this: If I have split views, one of which is PN with two Talking head tracks, and the other audio library, and I do a search for "beatles", both views will show all beatles tracks they contatain, which is zero for PN. But PN has been taken over by the se4arch, and you have to clear the search or restore playing now in order to drag any new tracks into it.
This doesn't happen with an interface plugin--MC doesn't search them, naturally. But what about an interface plugin that was actually a PN graphic proxy? It would be open to customizations and stickiness that PN in a view isn't.
-
- I had one song in Playing now and went to Preview it. While it was playing, I played around typing in the editor and then hit the Clear button since it didn't have real lyrics. I then clicked the Playing Now button from the tree without saving to see if the Lyrics field (I have a customized field added saying Yes or No) had been set to No. It hadn't as expected but then I got a popup error:
Unspecified Error (Exception from HRESULT: 0x80004005 (E_FAIL))
This caused it to close Media Center (version 183). BTW, this got the Incomplete Shutdown Detected message when MC started again.
- May be related to the above one. Opened up MC again and it had the one song in Playing Now with the lyrics. Went to Lyrics Editor plugin and hit Clear, Just Save Data, and then Playing Now in the tree. My Lyrics field was No which was good. Clicked Lyrics Editor again and MC just closed. Loaded up more songs and switching between Playing Now and Lyrics Editor, eventually closes MC when clicking on Lyrics Editor. Might be some conflict with another plug-in but before I debug further just wanted to mention it.
Ok, I figured out how to reproduce this. Basically all I had to do was go to the plugin, go to PN, then go back to the plugin and BAM.
I'll be damned if I can figure out why it's happening, though. I'm starting to think it's a BUG in MC. I've narrowed it down to one MC function that works fine unless you use it, then go to Playing Now, then try to use it again. I'm going to report it to the guys at JRiver and hopefully they'll be able to shed some light on it.
-
Ok, I reported the bug.
During my testing, I noticed that if the plugin's mode was set to always be active, then this problem goes away.
One nice thing about leaving the plugin always active is that you can leave it, then come back to it and pick up where you left off.
The downside to this is that if you're working with a playlist or Playing Now, then leave LE and make changes to that playlist or Playing Now, then come back to LE, the list of files you see is the list of files you had before you made that change.
So to get around that I tried having LE do a refresh whenever it repaints the main interface (which is the only event I can seem to get plugins to respond to inside MC - the usual ones you'd use for this don't seem to be generated). This works fine except that a repaint occurs both when you enter a plugin and leave the plugin. So if you're in LE, then click on Playing Now, LE will refresh it's file list before you can actually go to Playing Now. If the file list was relatively small, you probably wouldn't notice, but if you have a a couple of thousand files in the file list, there is a delay.
So as it stands now...
You can either have the plugin only be active when you're actually using it - in which case you get this weird crash thing until either JRiver fixes this bug, tells me that I'm using the function wrong, or I figure out some workaround.
or
Have it be active all the time - in which case the crash goes away and you get to pick up editing lyrics where you left off but then are faced with the choice to either may have to manually refresh the file list when you come back, or face a possible delay when you navigate away from the plugin.
In an ideal world, LE could catch some event from MC that lets it know that it's being entered, so it could do an automatic refresh then and only then. With the auto-refresh in place, I could lose the Refresh button as it would no longer serve any purpose.
So... opinions?
-
I'm not seeing the big deal with refreshing, D. For myself, at least, I have most of my lyrics via Sparta's automated plugin, now I'm just going through and cleaning them up. So I think having some way of knowing which lyrics you've cleaned is more important. If I have 10,000 lyrics, I'm loading and cleaning 100 at a time.
I think the preview/return functionality is really good, if that's part of the issue. The beauty of this is that it turns the LE GUI into an alternate playing now, IMO. Just some checkbox or other to indicate that the current file has been overwritten, and hopefully improved.
I hope you're kicking back and taking five after all this productivity. LE as it is is ready to go for fixing lyrics.
-
Out of curiosity, how are you using these? I've had such good luck just hitting the Google Search button that I never use the others.
I'm not currently using those as I'm just testing right now, but since they're there it seems like they should be in the "right" order. ;) I guess someone might want to use a search engine other than google or another tool that they would want to paste the artist and/or name into.
-
In your screenshots all your buttons are rounded.
Yet on my machine they come out square, anyone else getting this?
-
Might be kind of handy if the file list could be color coded. Something like:
Black = needs lyrics
Gray = has lyrics
Red = edited lyrics this session.
Now that I have figured out the acronyms... Is there a shortcut for opening PN in the AW?
-
I'm not seeing the big deal with refreshing, D. For myself, at least, I have most of my lyrics via Sparta's automated plugin, now I'm just going through and cleaning them up. So I think having some way of knowing which lyrics you've cleaned is more important. If I have 10,000 lyrics, I'm loading and cleaning 100 at a time.
I could probably add an option to display this. I'm running out of room on the form, though, and I'm loathe to go to a tabbed interface for such a simple plugin. I'll figure something out.
I think the preview/return functionality is really good, if that's part of the issue.
Nope, it's not part of the issue at all.
I'm not currently using those as I'm just testing right now, but since they're there it seems like they should be in the "right" order. ;) I guess someone might want to use a search engine other than google or another tool that they would want to paste the artist and/or name into.
Well, that's kind of what the button that copies Artist - Name is for. ;) And if you're switching out of MC to a web browser and back again to copy the individual fields, I'm not sure the order really matters.
In your screenshots all your buttons are rounded.
Yet on my machine they come out square, anyone else getting this?
What OS are you using? I'm using XP Pro here. But I think any of the older OS's will show the buttons as the old style.
-
Sush--
This is not the first time I've been called to task for talking gibberish, with or without the acronyms. tools/options/tree&view/custiomze toolbars has a view hot buttons, for example "tag info". However, the "Playing Now" button seems to work only with the current view, not the Action Window (AW). Is there a way to assign macros to open PN in AW to a button? Hmmm.
I think your idea of the color-codes is the right one. Dress things up a bit.
-
Might be kind of handy if the file list could be color coded. Something like:
Black = needs lyrics
Gray = has lyrics
Red = edited lyrics this session.
Not sure you can do that
In VB6 you can't with the built in list control from mircosoft.
would be nice to know info if .net can do this
-
I can understand why some VB 6 people got annoyed with it,
it is slow compared with VB6
why do you think VB .net is now free?
because everyone thought it sucked (IMHO)
I was talking to A Microsoft rep about a month ago about VB net, maybe when i get some money I will buy the Visual Suite, but i hate to spend that much money on software.
-
Might be kind of handy if the file list could be color coded. Something like:
Black = needs lyrics
Gray = has lyrics
Red = edited lyrics this session.
Now that I have figured out the acronyms... Is there a shortcut for opening PN in the AW?
I'm never going to get this thing finished, am I? ;)
-
Not sure you can do that
In VB6 you can't with the built in list control from mircosoft.
would be nice to know info if .net can do this
I'm sure it can be done. Even if it means overriding the Draw method for the listbox.
-
it is slow compared with VB6
why do you think VB .net is now free?
because everyone thought it sucked (IMHO)
I'm sure it's not free because "it sucks". It's free because it's a limited version that's perfect for people like me to download it for free, get used to it, then later when I'm a high priced programmer writing enterprise level database-driven apps, I can fork over a grand to get the real version.
-
Doof--
#1, I'm worried about you busting a vein over this project, so pace yourself.
#2, If you know of a way to do color-coding, great. Can this include some way to PERMANENTLY designate a lyrics file as having been edited? Like I said, Kingo's machine got me 10,000 lyric files, and I'm dead grateful. Now I have to go in and translate some of them from Albanian. Here's an example, from Scott McKenzie's "San Francisco"--originally written by John Phillips, modified (apparently) by the wild and crazy guys:
If you're going to San Francisco
Be sure to wear some flowers in your hand.
If you're going to San Francisco
You will meet some gentle people then. ["then" rhymes with "hand", you see.]
---and later---
There's a whole generation
With a new exponation.[no exponation necessary]
---and lastly, my favorite---
If you come to San Francisco
Summertime will be your loving hand.
-
When was the color coding added? I kept checking the end of the thread for updates and didn't notice anything until just now when I saw the first post.
Anyway, I know you don't want to make this into a tag editor, but it might be nice to let the user choose maybe 1-5 custom fields to add to the UI. I've used LE to search out a couple hundred lyrics in the last couple of days and several times it would have been handy to be able to change ratings and keywords as I go.
-
usue--
Any idea how to active options? Mine are all greyed out.
doof--
This is really lookin good.
-
okay d--
Here's the issue: not only are you making a great tag editor, you're making a better browser than IE. I use FF and am grateful that LE goes out to the default browser. This is all really cool stuff.
#1. Are the "options" supposed to be activated? I see that "Create database field" button but it's greyed out.
#2. Google search button is simple and effective. I've found some great lyrics sites and I'd like to bookmark them within LE (yes--LE), and instead of click on "google", what if there was a dropdown menu that defaulted to google but also could list bookmarked sites which I've now forgotten?
#3. Now that you have such a cool looking GUI for your lyrics/bio editor/browser, any thought to making it skinable?
-
When was the color coding added? I kept checking the end of the thread for updates and didn't notice anything until just now when I saw the first post.
Yeah, from here on out, the thread name will be updated to reflect the new build number and the first post will have the details about the changes. It just makes it easier for people to read up about the plugin and its features and download it all without having to scroll through the entire thread.
Anyway, I know you don't want to make this into a tag editor, but it might be nice to let the user choose maybe 1-5 custom fields to add to the UI. I've used LE to search out a couple hundred lyrics in the last couple of days and several times it would have been handy to be able to change ratings and keywords as I go.
I'll give it some thought. I'm trying to keep it's focus on just editing lyrics, but I can see the benefit to what you're asking.
usue--
Any idea how to active options? Mine are all greyed out.
The options don't work yet. Well, they mostly do in the build I'm using but right now I'm making a lot of internal improvements to make the code more portable, so it may be a day or two before you guys get to play with them.
doof--
This is really lookin good.
Thanks. :)
-
#2. Google search button is simple and effective. I've found some great lyrics sites and I'd like to bookmark them within LE (yes--LE), and instead of click on "google", what if there was a dropdown menu that defaulted to google but also could list bookmarked sites which I've now forgotten?
I've been mulling over some thoughts on this, like a dropdown that let you choose alternate search text. Hadn't really thought of putting in a favorites type system. I'm not really sure how that would work because not every site is searchable or searchable the same way. And if it's just going to replicate the Favorites/Bookmarks features of IE and FF, then is there really a point?
#3. Now that you have such a cool looking GUI for your lyrics/bio editor/browser, any thought to making it skinable?
Allegedly, MC can skin plugins. It seems to work for the included plugins (ie. Library Server) and RhinoBanga apparently got it working for his PlayingNow plugin (What little of it that actually resides inside MC), but I'll be damned if I can figure out how it's done. I've asked around, but so far I haven't gotten any responses.
-
.NET plugins can't be skinned by MC unfortunatley.
I found an old post by Matt on it, and apparently the
Buttons are of a slightly different style, and therefore
MC doesn't pick them up.
Maybe it should be a function of the template in the future,
to work out which skin is being used and pick up the graphics
as appropriate, lol :)
-
Hop to it! :P
Or maybe we should all bug the JRiver guys to make MC be able to skin .NET plugins...
-
Small request (I hope). Can you possibly change the File List to show:
#. Song Name (Artist)
instead of
#. Artist - Song Name
It's more important to see more of the song name for keeping your place, and chances are you're going to have several of the same artist in your list in a row. Plus it's just plain easier to infer the Artist from the song name than then other way around.
I also vote for going back to inexact searches in Google. The times I've had to remove quotes to get a match are higher than when I've had to add them to get a match.
Thanks and keep up the good work.
-
Also... I'm not married to this layout. I realized I was going to need to offer up some options, but I really didn't want to go to a tabbed interface. I thought of just sticking in a single button that would open up an options dialog, but once I cleared room for that, I realized I could fit all the options I wanted to use right on the main form. If anybody has any suggestions, feel free.
Thanks for all your work on this.... And for what it's worth, I really like the layout. I think it's very well laid out!
-
Doof,
I really like the layout but iot doesn't fit properly on my screen :( I am at 1024 x 768 and I lose the buttons at the bottom. Any way it could auto size to the space?
Adam
-
Great plugin :)
2 suggestions
Only show a list of audio tracks - not many of my pictures or vids have lyrics ;)
Some sort of formatting aid would be nice
Thanks
-
Great plugin :)
2 suggestions
Only show a list of audio tracks - not many of my pictures or vids have lyrics ;)
Some sort of formatting aid would be nice
Thanks
If you create a Audio only smartlist, you can choose that in the drop down.
That way you won't have pic or vids.
-
Only show a list of audio tracks - not many of my pictures or vids have lyrics ;)
I actually thought about doing this, and I don't think it would be that hard to do. Is anybody out there adding lyrics to images or videos? Just wondering if I should make it do it by default or as an option.
Some sort of formatting aid would be nice
I'm not sure I know what you're asking for.
-
imjustagamer
True, i'll edit all my smartlists to just audio, then add video and image ones
Only 3 times as many smartlists is needed ;) <only joking, I can see it'd be a quick fix for me>
I just can't see the reason for not filtering out the non-audio in the first place ?
Hmmm, music videos maybe? But I can't see me doing that, after all I couldn't read them and watch the video at the same time.
Re: formatting aid
I was thinking of capitalise first letter type things
It annoys me having different styles of lryics, some with every word capitalised, some with only the first word of the line
And don't get me started about spaces before the start of a line
Drives
Me
Crazy
;D
-
Doof, from EvilLyrics
if ( currentPlayingTrack.Get ( "Media Type", true ) == "Audio" )
{
}
Where currentPlayingTrack is of type IMJFileAutomation
Might be useful
-
Re: formatting aid
Also a quote converter would be handy
Some lyrics use ', some use `, and some use (one I can't even find on my keyboard) that tilts to the right
Depending on the font used, some of these show up as a square box
-
True, i'll edit all my smartlists to just audio, then add video and image ones
Only 3 times as many smartlists is needed ;) <only joking, I can see it'd be a quick fix for me>
I just can't see the reason for not filtering out the non-audio in the first place ?
Hmmm, music videos maybe? But I can't see me doing that, after all I couldn't read them and watch the video at the same time.
Re: formatting aid
I was thinking of capitalise first letter type things
It annoys me having different styles of lryics, some with every word capitalised, some with only the first word of the line
And don't get me started about spaces before the start of a line
Drives
Me
Crazy
;D
MC's built in Clean File Properties tool can do all this. You could just run it on all of the files in your library and be done with it. No need to fire up a seperate plugin and do each file manually.
-
Multiple blank line removal?
Multiple space removal ?
I love this plugin, i've been adding lyrics like there's no tomorrow
Just wish some of the lyrics sites would quit trying to install adware on my pc!
-
Doof, from EvilLyrics
if ( currentPlayingTrack.Get ( "Media Type", true ) == "Audio" )
{
}
Where currentPlayingTrack is of type IMJFileAutomation
Might be useful
That's exactly what I was thinking. :)
-
I actually thought about doing this, and I don't think it would be that hard to do. Is anybody out there adding lyrics to images or videos? Just wondering if I should make it do it by default or as an option.
I just started to use MC with music videos and I'm adding lyrics to them, so maybe you could set it as an option.
-
OK, just checked out the clean option in MC
I was thinking of a slightly more intelligent version
eg
Their 'capitalize first letter' works, but not in a very good way for lyrics
It ignores things that really should be uppercase like 'I' etc
Doesn't remove multiple blank lines
Leaves those pesky quote characters alone
@Deivirt
I was thinking on an 'Audio Only' checkbox on the form
Or possibly a combo box of audio/video/picture/all ?
-
@Deivirt
I was thinking on an 'Audio Only' checkbox on the form
Or possibly a combo box of audio/video/picture/all ?
Both solutions are good. Actually, anything that does not prevent from getting the lyrics for a video file would be fine for me.
Thank you.
-
It´s possible to do the interface a bit smaller? I have a 17' monitor and the buttons are too big...
-
Multiple blank line removal?
Yes… that would be handy.
I love this plugin, i've been adding lyrics like there's no tomorrow
Me too!
Just wish some of the lyrics sites would quit trying to install adware on my pc!
I haven't had much of a problem with Firefox + AdBlock Plus. There is one site that throws Avast Antivirus into a tizzy but I have learned to avoid it.
-
Doof--
I agree, it would be possible to fit the same functionality into a smaller space. As it is, though, I do a 75/25 split view with playing now and it fits fine. That's not to say we can't dream up additional functionality to wedge into the GUI.
I like the idea of some cleanup buttons, and it actually might not be as horrendously complex as it seems. (Mostly because you'd be doing the work, not me.) Some potential cleanup buttons:
--Remove top space. This would take out white until it hits words, not going into the lyrics to remove blank lines, however. You see, I'm busy cutting everything up into stanzas . . .
--Capitalize first word in line. Not only that, it would uncapitalize all other words.
--Capitalize all. This would do as promised, while offering a whitelist of articles that you might not want capitalized unless they start the line.
--Select whole line. Some way to right-click or otherwise select the entire contents of a line, so you could backspace it up to the previous line, cut/paste, etc.
Sorry to dump this all on ya, man. Your program is so good at what it does, I can't help thinking, what if it did more? I think you only really get to the end of the nightmare if you pretend to have fallen off the planet.
Doof? Doof?
-
New build up: 0.9.9.0.
Info is in the first post of this thread.
-
It´s possible to do the interface a bit smaller? I have a 17' monitor and the buttons are too big...
It resizes to fit into the total window size. The actual size of the plugin interface is much smaller. Check out the screenshot posted in the first post and you can see what it looks like in the designer.
-
It resizes to fit into the total window size. The actual size of the plugin interface is much smaller. Check out the screenshot posted in the first post and you can see what it looks like in the designer.
Not yet, the perfect size is 760, like websites. Now the size is 879.
-
What is it that you're seeing? I'm running it on a 17" monitor too and it looks fine. Are you having to scroll or anything to see it all? What resolution are you running at?
"The buttons are too big" is a bit vague.
-
Can you see it in a 800x600 resolution?
-
Can you see it in a 800x600 resolution?
People still use 800 x 600?
-
I´m not, but in my screen I´ve got on the right the playing now plugin. This night, when I´m home, I will post my screen and you will understand... I can see all the plugins ok, but yours not.
-
Thanks. Screenshots are always much more helpful. :)
But what resolution are you using?
-
I´m using 1024*768 but 1024 less the MC tree (Playing Now, Audio, Video...) and less the Playing now plugin.
-
Are you using the Playing Now plugin like a sidebar or something? Mine just pops up and disappears and doesn't chew up any screen real estate.
I just posted build buil 0.9.9.6. It's shrunk the size of the form down to 760 x 570. Let me know if it's better for you.
-
Doof--
Just going to dump a couple bugs on ya, sorry.
--"Return" in builds .9.5 and .9.6 will effectively START play in playing now, if you left with nothing playing. This is different than prior builds. However, if you left with something playing, it takes you back to where you were when you left, same as prior.
--Don't hit "Preview," if you don't have anything selected. The app runs over to the railing and blows chunks.
--"Create Database Field" Anything? Anything?
FWIW--I'm not sure that "Viewed (has...)" and "Viewed (no...)" are doing much for world knowledge. I ended up making them the same color as "Has" and "No". I think think the trigger will turn out to be "save count", or some such.
-
--"Return" in builds .9.5 and .9.6 will effectively START play in playing now, if you left with nothing playing. This is different than prior builds. However, if you left with something playing, it takes you back to where you were when you left, same as prior.
Yeah, I noticed that, too. I'll look into restoring the playback state as well as the other stuff when you click on "Return".
--Don't hit "Preview," if you don't have anything selected. The app runs over to the railing and blows chunks.
D'oh! Should be an easy fix, though.
--"Create Database Field" Anything? Anything?
Um.. what? It works here. What are you expecting it to do that it's not doing?
FWIW--I'm not sure that "Viewed (has...)" and "Viewed (no...)" are doing much for world knowledge. I ended up making them the same color as "Has" and "No". I think think the trigger will turn out to be "save count", or some such.
I'm not following you...
-
Doof, create Database Field is permanently greyed out on my machine. Is there something this is supposed to do?
As for Viewed. . ., the fact that I've viewed a lyric doesn't tell me if I've fixed it. If I've overwritten it, there's a better chance that it's right.
-
Doof, create Database Field is permanently greyed out on my machine. Is there something this is supposed to do?
1. Have you installed the latest version?
2. Have you checked the box that says "Save Viewed Status"?
3. Is the database field "LTEStatus" already in your database?
As for Viewed. . ., the fact that I've viewed a lyric doesn't tell me if I've fixed it. If I've overwritten it, there's a better chance that it's right.
You know.. I actually started working down that road and then for some reason I decided it wasn't a good idea. So I decided just storing whether or not you've viewed it was probably going to have to be good enough. Let me re-look at it, though. I may have been over-thinking it before.
-
Er, "the database field 'LTEStatus'? When were you planning on telling me?
-
Actually, D, there is such a field, LE made it for me. Save viewed status is checked, Create Database field is grey.
-
Er, "the database field 'LTEStatus'? When were you planning on telling me?
All of this has been detailed in the posts that list the new changes at the beginning of the thread. :P
-
Actually, D, there is such a field, LE made it for me. Save viewed status is checked, Create Database field is grey.
Right. If the database field is there, then you won't need to click the button, hence it being disabled. :P
You must have clicked on it yourself at one point because it won't create the field on its own.
-
How are you saving the tracks in database? I said that because if I edit the artist name or the track name, maybe I can lost data in Lyrics Editor.
-
How are you saving the tracks in database? I said that because if I edit the artist name or the track name, maybe I can lost data in Lyrics Editor.
Are you asking me if you can lose data or saying you have?
-
I´m asking you. Sorr for my bad english
-
Ferent--
I have not seen data loss. Be cautious with altering data. If you alter or remove data in "Artist" "Album" or "Name" and save it, those changes are made to your library fields.
-
Ok, thanks for the reply.
The size is perfect now too. Thanks a lot.
-
I could easily add little buttons next to any of the fields to enable editting of that field if anybody's worried about accidentally wiping stuff out.
Or even add an option to prompt on changes.
If anybody's interested.
-
Ok, thanks for the reply.
The size is perfect now too. Thanks a lot.
No problem. Glad it worked out. :)
-
New build, 0.9.9.9 Beta is up.
It's pretty much what a more glorious application would call a release candidate. The features are done (for this version). Only bug fixes from here on until I get some work done on the Captionater (marko's been waiting patiently).
-
1.0, my friend. (She's ready for her closeup, Mr. DeDoof).
Next stop: Sparta. I'm going to lay some clean lyrics on the King (shout if you want them also, D). Should only take 2 or 3 years to get it done.
-
I have .9.9.9 installed and have noticed that the tops of the following writing is cut off.
Search Aids
Options
Status
File Coloring
Navigation
File List
Get File List From
Here is a pic.
www.uppit.com/dl/LeNulBbg
-
Hey, how'd you get it to look like that? It looks skinned like the rest of MC...
-
Hey, how'd you get it to look like that? It looks skinned like the rest of MC...
hmmm Maybe that's why the text is a little off...
I'm using Windowblinds
Edit... The text problem stems from the skinning that Windowblinds does... If I turn it off, the text looks fine.
Sorry for the trouble.
-
hehe... no biggie. I've just been struggling with how to get MC to skin the plugin and I was hoping that you'd stumbled upon the trick somehow. :)
-
I'm having great luck using Lyrics Editor. At one time the playlist selection box had no limit and it scrolled off the screen and it was shrunken down to 8 rows (at least on mine). Since it's pulling playlists from all the MC standards plus anything I have created plus some things I have no idea what they are, it's a lot of scrolling now. Can the size of the box be increased at least double? In addition there doesn't seem to be any order in the playlists, like alphabetized would be, so it's very hard to find the file list I want.
During editing I went and created a new playlist. I went back to LE, refreshed the box, but the new playlist was not in the drop down. The only way I could get it to appear was to close MC and restart.
I just tried the LTEStatus. I like it. :)
-
Hey, guys... Just wanted to give you a status report since it's been a while since I've posted anything.
I got the plugin to now alphabetize the playlists combox. It was actually a lot of fun because I got to learn something new. :)
I also doubled the size of the playlist dropdown, so hopefully between that and the alphabetizing, the whole dropdown should be much friendlier now.
I also started a semi-rewrite of the code that should make the individual routines more portable into other plugins. I'm planning on using several of them in the Captionater plugin and maybe another one I just thought of the other night. In the process, I introduced a really nasty bug that's proving to be extremely elusive. If not for this bug, version 1.0 would be available for download.
So... just wanted to let you know what's going on and that I haven't stopped working on it. :)
-
Thanks for the update
-
Ok, 1.0 is out. It underwent a pretty significant re-write, but it appears to be bug free (I think). Beat on it a while and let me know if anything bad happens. :P
Details are in the first post of this thread.
-
Just posted 1.0.1 which fixes a minor crash-inducing bug. :P
-
Just posted a new build (1.0.2). Nothing major - just added tooltips for the file list. May stay, may not, will probably wind up an option. :P
It was just something I noticed I could do so I did it. ;)
-
Thank you very much for the great plugin. Was already a big help for me.
Sometimes I would like to skip the changes I made in the main window. Is there a way to proceed to the next file or exit the plugin without saving?
U.
-
Sometimes I would like to skip the changes I made in the main window. Is there a way to proceed to the next file or exit the plugin without saving?
Not yet, but I was thinking of a couple of different ways to do this... I'll probably do both..
1. Add an option to either save on file change (llike it currently does) or require you to click Save for changes to be saved
2. Add a "Skip To Next Without Saving" button
I personally like how it allows you to very quickly make changes and move on without having to click save every time. It makes it a kind of inline tag editor for Lyrics, similar to what we have for most of the other, simpler, fields. But I could easily add the options I listed above.
-
2. Add a "Skip To Next Without Saving" button
Personally would prefer this idea. The workflow remains fluent (less clicking) for normal editing.
U.
-
Doof--
Thanks again for all your hard work. Not sure why you would continue to sign up for so much pain, but I'm glad you do!
--In file list, colors no longer update if "Just save data" is pressed to save, rather than "next", which works as expected. LTEStatus field is updated properly in either case.
--Somebody mentioned pre-screening for audio tracks only. This might be a enhancement.
--I think #2 is most important, although you could introduce #1 at the same time.
-
Here's another one: If you select "Playing Now" in "Get file list from", and then "preview" a track, rather than play in PN, the selected track overwrites PN and all other tracks are cleared from PN. Refreshing via "Get File List From"/PN confirms this.
-
Ok, 1.1 is now available for download.
I added the "Next (No Save)" button, and fixed the bug where it wouldn't update the status color when using the "Just Save Data" button.
-
Thank you again! Can now skip my entries, when I messed something up.
Minor problem:
There is a .NET message when you press the <Next (No Save)> key on the last track.
-
Just posted build 1.2, which fixes that bug and adds a couple of new things.
-
Here's another one: If you select "Playing Now" in "Get file list from", and then "preview" a track, rather than play in PN, the selected track overwrites PN and all other tracks are cleared from PN. Refreshing via "Get File List From"/PN confirms this.
Yeah, that's how it works. It has to stop MC from playing what it's currently playing and then play what you wanted. It seemed the easiest way to accomplish this was to wipe PN, play the file you asked it to, then repopulate PN once you "Return".
-
Did anybody who installed the latest build lose their Refresh button? Somehow it got pushed over underneath something else, but I wasn't sure if it was the copy I was working on here, or if I posted it like that...
-
Yeah, I meant to say that PN is failing to repopulate, at least after hitting "Just save data". Only the preview track is left in PN. This is true of 1.0.2 and 1.2.0 (last 2 versions).
--NEW: The refresh button is gone from the "Get File List From" function.
--Still There: "Just save data " doesn't update the color scheme to green.
-
Yeah, I meant to say that PN is failing to repopulate, at least after hitting "Just save data". Only the preview track is left in PN. This is true of 1.0.2 and 1.2.0 (last 2 versions).
It'll only repopulate if you click the "Return" button.
--NEW: The refresh button is gone from the "Get File List From" function.
I'll upload a new build that fixes that.
--Still There: "Just save data " doesn't update the color scheme to green.
This is working for me. You won't actually be able to see the color change until you move to a new file though, due to the item being highlighted from being the selected item.
-
I posted in the regular MC forum that for some reason MC wouldn't start. The splash screen would appear and that's it. I uninstalled Lyrics Editor and MC would start. This combination works fine on one of my computers, however on my laptop this problem happens. I know I used to have a version of Lyrics Editor that worked on the laptop so something changed in recent versions to cause the problem.
-
Doof,
Thanks to your clear and straightforward program interface, I'm confident I know how the program works (thanks to your efforts). Every version after .9.9.9 has been broken for me. Currently I experience:
--Failure to repopulate PN after using "preview" and "just save data" and then returning via "return".
--Failure of the "return" button to activate once preview has been enabled, necessitating stopping the playback externally.
--The lack of a refresh button for "Get file list from", which you know about.
Doof, it's only thanks to your efforts that we have this great plugin. I'm happy to try your next rev, but at this point I have to believe that the issues I'm experiencing are only happening on my machine. So I'm happy to go back to .9.9.9, which I believe was perfect as it was. Thank you again for your hard work and great plugin!
-
--Failure to repopulate PN after using "preview" and "just save data" and then returning via "return".
Ah, ok... I'm following you, now. And I've reproduced it. You gotta be clearer with your bug reports, man! ;)
-
Ok, 1.2.1 sees the return of the refresh button and hopefully a smarter "Return" button.
Let me know if this clears up all the things you were seeing, j.
-
I posted in the regular MC forum that for some reason MC wouldn't start. The splash screen would appear and that's it. I uninstalled Lyrics Editor and MC would start. This combination works fine on one of my computers, however on my laptop this problem happens. I know I used to have a version of Lyrics Editor that worked on the laptop so something changed in recent versions to cause the problem.
Ok, I think I've reproduced this. By any chance, was Playing Now on your laptop empty when you started seeing the problem? If so, then I think I got it fixed. Download the newest build (1.2.2) and let me know if it takes care of it.
-
Ok, I think I've reproduced this. By any chance, was Playing Now on your laptop empty when you started seeing the problem? If so, then I think I got it fixed. Download the newest build (1.2.2) and let me know if it takes care of it.
There's probably a 99% chance that Playing Now was empty. Before I close MC, I usually clear Playing Now and do a backup so another machine on my network can do a restore of the library. No real reason to clear Playing Now. When I get home, I'll download the latest version and try it. Thanks!
-
Doof, yes, the latest build is now working on my laptop. Yay! I like the looks of the toolbar. You're going way overboard in the little simple editor I had requested. ;D
-
Doof, yes, the latest build is now working on my laptop. Yay! I like the looks of the toolbar. You're going way overboard in the little simple editor I had requested. ;D
You haven't seen anything, yet. ;)
-
Doof,
Great progress since I looked at it last (v.9.9.9).
With the current design, is there a way to allow clicking on a song (or hitting a button) in your plug-in and have that song played? I see not need to try to sync the player with all of the navigation in the plug-in, but it would be nice to do it for slected tracks.
Randy
-
You can click the "Preview" button under the file list and it will play the selected song. If you were listening to something before that, when you click "Return" it'll go back to what it was playing before.
I'm planning on adding another button that will do the same thing, but with the entire selected playlist.
-
Hey, everybody. Um... don't spend a lot of time cleaning up your lyrics just yet...
-
All right Doof, you have to give a little more reason why. I have a nice 3 day weekend and those thousands of songs without lyrics are just inviting me!
-
Well, dig up all the lyrics you want. Just don't waste a lot of time cleaning them up.
There may be something coming soon that will make that particular job a lot easier. ;)
-
Will do. This sounds like something good is coming. Like capitalization of first character in each line and not capitalized words in the rest of the line except for words like I, spell checking, etc. Can't wait!
-
Yeah, spell checking's going to be a little tricky. I've got a couple of ideas on how to do it, but we'll see how it shakes out.
-
I agree, spell checking is going to be tough in order to get a dictionary. There's so many words in lyrics that are shortcuts like nothin' instead of nothing. There probably will be a lot of words that the user will need to add to the dictionary.
-
I have a spell check plug-in i think it works on the lyrics field, i forget now.
it comes with a small dictionary, but you can add words when it finds something it does not know. it works on what is called the soundx principle to come up with suggested words.
-
Almost there...
-
I've got a request for you (again...)
Currently you use three colours for the file display (no lyrics, lyrics, updated)
The best way i've found is
no lyrics - red
lyrics - black
updated - green
A nice and easy traffic light system for getting all the missing lyrics :-)
So, this is where it all goes a bit wrong
Some tracks in an album may be instrumentals and they show up as missing lyrics obviously
I must use 'No Lyrics' (or similar) as the lyrics to stop them showing up as missing the lyrics
Would it be possible to be able to mark a track as instrumental or something ?
Thanks for your consideration
Karl
-
I've got a request for you (again...)
Currently you use three colours for the file display (no lyrics, lyrics, updated)
The best way i've found is
no lyrics - red
lyrics - black
updated - green
A nice and easy traffic light system for getting all the missing lyrics :-)
So, this is where it all goes a bit wrong
Some tracks in an album may be instrumentals and they show up as missing lyrics obviously
I must use 'No Lyrics' (or similar) as the lyrics to stop them showing up as missing the lyrics
Would it be possible to be able to mark a track as instrumental or something ?
Thanks for your consideration
Karl
Well, what I do is stick [Instrumental] into the Lyrics field. That's how I've been handling these, how I've seen various lyrics sites doing it, and I know a bunch of people in here are doing the same. I've actually added a button to LE that sets the lyrics to this (the actual text is configurable).
-
Sssoooooo.....
how about a 'put that 'instrumental' part in button or similar
:)
-
Isn't that what I said? ;)
-
I'm thinking that as long as nothing catastrophic happens at work tomorrow, or I guess I should say later today, LyricsEditor 2.0 may just rear its ugly head.
-
Yaaayy - drooling with anticipation :)
-
Lyrics Editor 2.0 is out. Check the new thread titled "Lyrics Editor 2.0"