INTERACT FORUM

Windows => Third Party Plug-ins, Programs, and Skins => Topic started by: thomaspf on May 01, 2007, 06:47:48 pm

Title: Flac encoder plugin 2.2.0 broken?
Post by: thomaspf on May 01, 2007, 06:47:48 pm
Hi,

I had some issue with garbled content when using the the 2.1.1 plugin with two concurrent conversions and upgraded to the 2.2.0 version released 4/28/2007.

Now it seems that MC12.0.222 is crashing on my Vista machine after any attempted encoding. Is that just me or is anyone else seeing this as well?

Cheers

   Thomas

Title: Re: Flac encoder plugin 2.2.0 broken?
Post by: scthom on May 01, 2007, 08:04:42 pm
Hmmm.  Vista is a bag of tricks, isn't it.  Don't have it here, so not able to really test it at all.  Sorry for making you all the guinea pigs.
Title: Re: Flac encoder plugin 2.2.0 broken?
Post by: escaflo on May 01, 2007, 09:10:39 pm
I manage to transcode about 3000+ worth of APE songs to FLAC...
There were about 3 or 4 times it crashes. No particular pattern can be noted from the crashes. It crashes on normal english filenames but didn't crash on the unicode filenames.
Title: Re: Flac encoder plugin 2.2.0 broken?
Post by: thomaspf on May 01, 2007, 09:14:00 pm
I'd be happy to test. I have a bunch of machines with a couple of version of MC and Windows.

In version 2.1.1 doing parallel encoding results in garbage and there is quite a long delay after the encoding before the download starts during which MC freezes completely.

Thanks a bunch for doing this plugin!

Cheers

   Thomas
Title: Re: Flac encoder plugin 2.2.0 broken?
Post by: scthom on May 01, 2007, 11:32:14 pm
Sorry, I must not have been reading well the first time.  I suspect parallel processing is not going to work well.  Only a single copy of a DLL is used for multiple instances, so parallel calls to encoding and buffers will inevitably create trash.  I'm not sure threads are even a way to address that since the current plugin architecture doesn't have any way to identify separate processes.
Title: Re: Flac encoder plugin 2.2.0 broken?
Post by: TheLongshot on May 01, 2007, 11:54:24 pm
There is definitely something going on with the new FLAC encoder.  I just installed it and I've been having problems with it crashing.  I have an XP machine.

It doesn't seem to like playing and ripping at the same time.  I had no problem with the previous version with that.

Jason
Title: Re: Flac encoder plugin 2.2.0 broken?
Post by: thomaspf on May 02, 2007, 12:03:32 am
2.2.0 also crashes if I select only a single conversion at a time. I am surprised about the comment that parallel encoding is unsupported by the plugin architecture.

Maybe someone from JRiver can clarify?

Cheers

   Thomas
Title: Re: Flac encoder plugin 2.2.0 broken?
Post by: escaflo on May 02, 2007, 04:48:16 am
Just tested this. Try to rip a CD straight into FLAC crashes MC. It is pretty consistent, I've tried about 3 or 4 times. In the end, I've to rip to APE then convert to FLAC.

Not playing music while doing this.

Cheers!
Title: Re: Flac encoder plugin 2.2.0 broken?
Post by: scthom on May 03, 2007, 08:50:41 am
I'll take a look and see if I can find the problem.  Busy the next couple of days, so not until the weekend...
Title: Re: Flac encoder plugin 2.2.0 broken?
Post by: scthom on May 05, 2007, 08:17:29 pm
I was able to verify that parallel RipAndEncode processes create trashed audio (the files are technically valid).  Parallel ripping and encoding separately did NOT create trashed audio.  At least for now, use Advanced Ripping Options to either:


I did find one memory problem with a BSTR, so that may be the fix for the crashes.
Title: Re: Flac encoder plugin 2.2.0 broken?
Post by: scthom on May 05, 2007, 09:22:41 pm
Update: I moved the static buffer inside the encoder object, and that seems to have done the trick, so the new version 2.2.1 should work for you now.
Title: Re: Flac encoder plugin 2.2.0 broken?
Post by: stubbsy on May 06, 2007, 02:37:11 am
Thanks for fixing this so quickly Scot. It was driving me nuts having to convert to APE then to FLAC to avoid crashes.
Title: Re: Flac encoder plugin 2.2.0 broken?
Post by: escaflo on May 06, 2007, 09:23:40 am
Thanks for the quick update. I will test it when I got the chance.

Cheers!
Title: Re: Flac encoder plugin 2.2.0 broken?
Post by: kevind on June 06, 2007, 01:05:26 am
I just upgraded and now every CD ripped does this at the end of the rip

(http://www.dennehy.net/jriversflacerror.jpg)
Title: Re: Flac encoder plugin 2.2.0 broken?
Post by: Alex B on June 06, 2007, 03:48:39 am
Since you embed cover art in the tags the problem could be related to this:

http://yabb.jriver.com/interact/index.php?topic=40916.msg279424#msg279424