INTERACT FORUM

Please login or register.

Login with username, password and session length
Advanced search  
Pages: [1]   Go Down

Author Topic: [BUG?] Black bar detection & video analysis does nothing  (Read 632 times)

mattkhan

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 4191
[BUG?] Black bar detection & video analysis does nothing
« on: April 18, 2023, 11:22:50 am »

for a small no of files in my library, these functions do nothing and return v quickly. The corresponding items are playable. The logs suggest the task does execute, for exmaple

Code: [Select]
0000059: 3408: CD: BDROM::Scan: Start
0000059: 3408: CD: BDROM::Scan: Scanning stream clip files...
0000062: 3408: CD: BDROM::Scan: Scanning stream files...
0000062: 3408: CD: BDROM::Scan: Scanning playlist files...
0000063: 3408: CD: BDROM::Scan: Finish (4 ms)
0000063: 3408: CD: JRBlurayHelper::SetFilename: Completed BDROM scan
0000063: 3408: CD: JRBlurayHelper::SetFilename: Found 4 playlists and did the sorting.
0000064: 3408: CD: JRBlurayHelper::SetFilename: Finish (52 ms)
0000070: 3408: Encoders: CJRVideoAnalyzeExtended::AVLog: [mpegts @ 000002B3A2BF58C0] parser not found for codec pcm_bluray, packets or times may be invalid.
0000070: 3408: Encoders: CJRVideoAnalyzeExtended::AVLog: [mpegts @ 000002B3A2BF58C0] parser not found for codec pcm_bluray, packets or times may be invalid.
0000070: 3408: Encoders: CJRVideoAnalyzeExtended::AVLog: [mpegts @ 000002B3A2BF58C0] parser not found for codec pcm_bluray, packets or times may be invalid.
0000070: 3408: Encoders: CJRVideoAnalyzeExtended::AVLog: [h264 @ 000002B3A2BF7680] Reinit context to 1920x1088, pix_fmt: yuv420p
0000073: 3408: Encoders: CJRVideoAnalyzeExtended::AVLog: [mpegts @ 000002B3A2BF58C0] parser not found for codec pcm_bluray, packets or times may be invalid.
0000074: 3408: Encoders: CJRVideoAnalyzeExtended::AVLog: [mpegts @ 000002B3A2BF58C0] parser not found for codec pcm_bluray, packets or times may be invalid.
0000074: 3408: Encoders: CJRVideoAnalyzeExtended::AVLog: [mpegts @ 000002B3A2BF58C0] parser not found for codec pcm_bluray, packets or times may be invalid.
17527660: 9836: General: CReferenceCountedSocket::Close: SOCKET_DEBUG: closesocket() closing 3688
17527660: 9836: General: CReferenceCountedSocket::Close: SOCKET_DEBUG: closesocket() closing 4232
0000081: 6356: Encoders: CJRVideoAnalyzeExtended::AVLog: [h264 @ 000002B3A32E0B00] Reinit context to 1920x1088, pix_fmt: yuv420p
0000110: 3408: Encoders: CJRVideoAnalyzeExtended::AVLog: [AVIOContext @ 000002B3A2BF5DC0] Statistics: 1208464 bytes read, 2 seeks
0000110: 3408: General: JRWorker::ProcessCommand: AnalyzeVideoBlackBars succeeded...
0000113: 3408: General: JRWorker::ProcessCommand: Task completed in 102 ms, result = 0
0000114: 3408: General: JRWorker::ProcessCommand: Finish (105 ms)

in this case, Video Crop remains empty after execution.
Logged

Hendrik

  • Administrator
  • Citizen of the Universe
  • *****
  • Posts: 10923
Re: [BUG?] Black bar detection & video analysis does nothing
« Reply #1 on: April 18, 2023, 11:59:02 am »

If its all Blu-ray structures, I wonder if its selecting a m2ts file thats just too short or something like that. I'll add some logging to tell us which file it picked, maybe that'll shed some light.
Logged
~ nevcairiel
~ Author of LAV Filters

mattkhan

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 4191
Re: [BUG?] Black bar detection & video analysis does nothing
« Reply #2 on: April 21, 2023, 01:42:28 pm »

not sure if related but where is HDR Average & Peak Luminence coming from? is it the on disc metadata for MaxFALL and MaxCLL? just wondering why some tracks have blanks in these fields
Logged

Hendrik

  • Administrator
  • Citizen of the Universe
  • *****
  • Posts: 10923
Re: [BUG?] Black bar detection & video analysis does nothing
« Reply #3 on: April 21, 2023, 01:58:35 pm »

Yes, average and peak is MaxFALL and MaxCLL respectively. Not all files have it. Its a bit more on the optional side of metadata, and JRVR for example doesn't use it at all for tone mapping (although it does pass it to the display if pass-through is on).
Logged
~ nevcairiel
~ Author of LAV Filters

mattkhan

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 4191
Re: [BUG?] Black bar detection & video analysis does nothing
« Reply #4 on: April 22, 2023, 01:08:04 pm »

I spent some time working through the "bad" files and eventually I worked out that a number of them actually were bad for various reasons

1) paths were wrong due to something that looks like a partial move done by MC, the index.bdmv was in one dir and the content was in another
2) some files which were not 3d but were flagged in MC as 3dbdmv
3) assorted DVDs (which I converted to mkv and reimported)

after all this, I am left with just 2 BDs, both of which play just fine and seem complete on disk. It would be nice to get them scanned and/or find out what's wrong with it but otherwise I guess I can probably just reimport as mkv.



Logged

mattkhan

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 4191
Re: [BUG?] Black bar detection & video analysis does nothing
« Reply #5 on: April 22, 2023, 01:10:46 pm »

a few other things that would be nice to improve

1) it doesn't appear to be multi threaded, i.e. does 1 at a time, but is done on the cpu so it can take a while
2) since analysis doesn't necessarily fill every field, it can be a bit tricky to work out which entries are not analysed
3) auto import doesn't appear to consistently run the analysis in my setup (not sure why)

3 combined with 2 is a mildly annoying, I imagine this is to do with MC auto import not being aware of BDMV dir structure hence starts the imports before all files are copied to the drive (I rip on one machine and then transfer to NAS) so I probably need to just turn off video import (though that's not ideal)

feels like it should really have same UX as audio analysis (pick how many run concurrently, a dialog to show progress, can tell you if it's already analysed or not)

Logged
Pages: [1]   Go Up