INTERACT FORUM

Please login or register.

Login with username, password and session length
Advanced search  
Pages: [1]   Go Down

Author Topic: Exporting Playlists Deleted Entire Directory  (Read 1254 times)

StarVector11

  • Recent member
  • *
  • Posts: 15
Exporting Playlists Deleted Entire Directory
« on: April 23, 2018, 02:51:49 am »

The seemingly benign 'Export All Playlists' destroyed over 100 GB of files in my D:\Dir\ directory.

I saw it happen with the folder open with my own eyes, while it processed. Oh how nice, I have the playlists that I no longer have time to listen to.

During the process, the Directory was typed in as "D:\Utilities\Applications\J River\Playlists" but the selected 'folder item' in the dialog box was just "D:\Utilities\". I'm not saying that this is expected user behavior, but ...
Logged

RoderickGI

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 8186
Re: Exporting Playlists Deleted Entire Directory
« Reply #1 on: April 23, 2018, 03:22:42 am »

That's no fun.

I just tested the process quickly, and it seemed to work fine, produced the playlist files and didn't delete anything. I will note that you said you 'typed in as "D:\Utilities\Applications\J River\Playlists"', whereas I think MC expects you to select the target directory using the directory tree it displays. That shouldn't be an issue as long as the target directory existed, but it may result in an unexpected outcome. There is at least one MC process that will not work if you type in the target directory, and you must use the directory tree to select an existing directory. That may have been the "Rename, Move, & Copy File" function.

Regardless, MC "never" deletes media files, unless you tell it to. Is it possible that you accidentally selected all files in that directory and dragged them to a new location without realising it? That is easy to do in Windows, and would result in what you observed, although the files would still exist somewhere on your disk or a connected device. Unless the files were dragged to the Recycle Bin I guess.

Have you searched for the files to see if they are still there somewhere?

Note however, that I have seen Windows allows me to drag or move file to a non-existent directory, and just had them vanish. Once. But I didn't have enough evidence of what really caused the issue, as the PC was playing up a bit at the time.


I hope you have good backups.
Logged
What specific version of MC you are running:MC27.0.27 @ Oct 27, 2020 and updating regularly Jim!                        MC Release Notes: https://wiki.jriver.com/index.php/Release_Notes
What OS(s) and Version you are running:     Windows 10 Pro 64bit Version 2004 (OS Build 19041.572).
The JRMark score of the PC with an issue:    JRMark (version 26.0.52 64 bit): 3419
Important relevant info about your environment:     
  Using the HTPC as a MC Server & a Workstation as a MC Client plus some DLNA clients.
  Running JRiver for Android, JRemote2, Gizmo, & MO 4Media on a Sony Xperia XZ Premium Android 9.
  Playing video out to a Sony 65" TV connected via HDMI, playing digital audio out via motherboard sound card, PCIe TV tuner

RD James

  • Citizen of the Universe
  • *****
  • Posts: 1871
Re: Exporting Playlists Deleted Entire Directory
« Reply #2 on: April 23, 2018, 03:38:53 am »

Can confirm: Media Center wipes out all data in whatever directory you select to export to rather than being well-behaved and putting them in a subfolder, or even warning the user / asking for confirmation.
It also defaulted to using: %APPDATA%\J River\Media Center 24\Library
 
There are a number of actions in Media Center which should be asking for confirmation (if not twice) which does not.
Any time Media Center is doing more than writing tag changes to files it should be asking for confirmation.
And even then, I would prefer to make tag writing manual, but the current options make that a real hassle to deal with.
Logged

Matt

  • Administrator
  • Citizen of the Universe
  • *****
  • Posts: 42418
  • Shoes gone again!
Re: Exporting Playlists Deleted Entire Directory
« Reply #3 on: April 23, 2018, 08:06:56 am »

We'll add a confirmation message to the next build.  Sorry if you lost anything because of this.
Logged
Matt Ashland, JRiver Media Center

RD James

  • Citizen of the Universe
  • *****
  • Posts: 1871
Re: Exporting Playlists Deleted Entire Directory
« Reply #4 on: April 23, 2018, 08:16:10 am »

We'll add a confirmation message to the next build.  Sorry if you lost anything because of this.
I feel like automatically writing the files to an \Exported-Playlists\ directory (or similar) rather than replacing the entire directory might be a safer option.
Logged

dtc

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 3120
Re: Exporting Playlists Deleted Entire Directory
« Reply #5 on: April 23, 2018, 08:52:07 am »

"Export All Playlists" should not delete anything.  A warning is not sufficient.  The option should write the playlists without deleting anything.
Logged

dtc

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 3120
Re: Exporting Playlists Deleted Entire Directory
« Reply #6 on: April 23, 2018, 12:16:42 pm »

There are programs, some free,  that are pretty good at recovering deleted files, as long as you have not done much to the disk since the deletion. If you don't have a backup I would stop other activity on the disk and try one of them.  I have not used one in a while, so do not have any recommendations. Maybe someone else does.
Logged

swiv3d

  • Guest
Re: Exporting Playlists Deleted Entire Directory
« Reply #7 on: April 23, 2018, 02:15:23 pm »

Just tested this. Made a folder called playlist on my g: drive and populated with 11 folders containing three gb of music files. Selected export all playlists with G://Playlists selected as the destination from the browse tree. When the playlists are saved they are stored in the requested folder but 10 of the 11 folders of music files disappear and are not in the recycle bin and don't turn up when the drive is searched. So yes, export all playlists does delete files in the folder selected for output.

Edit: On returning to the G://Playlists folder to delete the exported playlists  I find that even the single remaining music folder has vanished too. So Export all playlists does delete everything previously in the slected folder, with no warnings.
I can forsee a gaggle of unhappy MC users if this isn't corrected immediately.
Logged

RoderickGI

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 8186
Re: Exporting Playlists Deleted Entire Directory
« Reply #8 on: April 23, 2018, 03:21:45 pm »

Can confirm: Media Center wipes out all data in whatever directory you select to export to rather than being well-behaved and putting them in a subfolder, or even warning the user / asking for confirmation.
It also defaulted to using: %APPDATA%\J River\Media Center 24\Library

Okay, my testing was a bit too quick, and Windows Explorer hadn't refreshed.

It does delete everything. It does default to the library directory. I had to restore my testing library after running this.

"Export All Playlists" should not delete anything.  A warning is not sufficient.  The option should write the playlists without deleting anything.

I completely agree with this. Why would writing new files to a directory delete everything in there? If a user was updating playlists it should just overwrite any existing ones with the same name, and add new ones. Maybe the intent was to delete all playlist files so as to avoid having Windows overwrite confirmation messages popup, but the effect is pretty disastrous!
Logged
What specific version of MC you are running:MC27.0.27 @ Oct 27, 2020 and updating regularly Jim!                        MC Release Notes: https://wiki.jriver.com/index.php/Release_Notes
What OS(s) and Version you are running:     Windows 10 Pro 64bit Version 2004 (OS Build 19041.572).
The JRMark score of the PC with an issue:    JRMark (version 26.0.52 64 bit): 3419
Important relevant info about your environment:     
  Using the HTPC as a MC Server & a Workstation as a MC Client plus some DLNA clients.
  Running JRiver for Android, JRemote2, Gizmo, & MO 4Media on a Sony Xperia XZ Premium Android 9.
  Playing video out to a Sony 65" TV connected via HDMI, playing digital audio out via motherboard sound card, PCIe TV tuner

swiv3d

  • Guest
Re: Exporting Playlists Deleted Entire Directory
« Reply #9 on: April 26, 2018, 01:46:17 pm »

I see that this problem has been sorted in 24.0.19.  A quick response well done all.
Logged

RD James

  • Citizen of the Universe
  • *****
  • Posts: 1871
Re: Exporting Playlists Deleted Entire Directory
« Reply #10 on: April 26, 2018, 02:12:26 pm »

"Export All Playlists" should not delete anything.  A warning is not sufficient.  The option should write the playlists without deleting anything.
Agreed.

That's why I suggested that it could create a specific sub-folder, such as \Exported-Playlists\ in the selected output directory.
It should also not overwrite anything in that folder if it already exists, but that's why it should be something likely to be unique rather than simply \Playlists\
 
Or perhaps the easier solution is to provide an error if the selected directory is not empty, and do not allow playlists to be exported to a directory that already contains files.
Logged

JimH

  • Administrator
  • Citizen of the Universe
  • *****
  • Posts: 72478
  • Where did I put my teeth?
Re: Exporting Playlists Deleted Entire Directory
« Reply #11 on: April 26, 2018, 03:06:34 pm »

In MC 24.0.19, it doesn't delete anything.
Logged

RD James

  • Citizen of the Universe
  • *****
  • Posts: 1871
Re: Exporting Playlists Deleted Entire Directory
« Reply #12 on: April 26, 2018, 03:29:27 pm »

In MC 24.0.19, it doesn't delete anything.
My mistake. I saw that a prompt had been added in 24.0.18, but missed that it was then removed in the next version.
I still think that saving to a sub-folder if the current folder is not empty would be a better solution, but at least it is "safe" now.
Logged
Pages: [1]   Go Up