INTERACT FORUM

Please login or register.

Login with username, password and session length
Advanced search  
Pages: [1]   Go Down

Author Topic: libbluray update request  (Read 493 times)

bogdanbz

  • World Citizen
  • ***
  • Posts: 208
libbluray update request
« on: April 11, 2023, 01:06:34 pm »

Sometimes when playing the main HDR feature on a UHD HDR BluRay disk in menu mode, then trying to view the SDR extras on it, the colors are wrong because the renderer still happens to use BT2020 color space.

I noticed a commit (88f9d05d) on libbluray which does a color space comparison between streams, maybe it improves this use case. So I would like to request an update of the libbluray library used by MC, if possible.
Logged

Hendrik

  • Administrator
  • Citizen of the Universe
  • *****
  • Posts: 10925
Re: libbluray update request
« Reply #1 on: April 11, 2023, 04:38:33 pm »

libbluray is not involved in any processing of the video color.

If you use JRVR, it should be capable of dynamically switching between SDR and HDR. madVR has historically had some issues with that.
Logged
~ nevcairiel
~ Author of LAV Filters

bogdanbz

  • World Citizen
  • ***
  • Posts: 208
Re: libbluray update request
« Reply #2 on: April 12, 2023, 02:11:20 pm »

Even if this doesn't get solved, I think it would still be worth updating the library. There are a few fixes and improvements that we could benefit from.

Btw, I noticed the library can receive the red, green, yellow and blue (BD_VK_RED, BD_VK_GREEN, BD_VL_YELLOW, BD_VK_BLUE) button presses, passed to it the same way the up, down, left, right button presses are passed to it (BD_VK_UP, BD_VK_DOWN, BD_VK_LEFT, BD_VK_RIGHT). The key constants are defined in src/libbluray/keys.h.

This would make it possible to implement the BluRay menu color buttons feature, by sending these keys to the library on receiving the USB Consumer Menu Controls 69 to 6C (Red/Green/Blue/Yellow Menu Button) key presses. (a multimedia keyboard is both a USB Keyboard and a USB Consumer Control device - the Play/Pause, Stop, Volume Up, etc. keys are sent as Consumer Control key presses not as Keyboard key presses; the USB receiver of a remote is also a USB Consumer Control device, and sometimes a USB Keyboard too, and will send Consumer Control key presses when the Red/Green/Blue/Yellow keys of the remote control are pressed just as it sends Consumer Control key presses when the Volume Up, Volume Down, Play, Stop keys are pressed on it).

The USB Consumer Controls are listed in the Universal Serial Bus HID Usage Tables (link).
Logged
Pages: [1]   Go Up