Topic: Subtitles Cut Off (Read 1982 times)

Ashfall · « **on:** May 08, 2024, 08:57:36 am »

Hello,

Text based subtitles are cut off on the left by a few pixels. This is only visible when the leftmost character is a very wide character such as W or T.

Screenshots below.

bogdanbz · « **Reply #1 on:** May 10, 2024, 12:32:17 pm »

I can confirm this, it's an old issue that I kept on avoiding to report myself.

It affects both text and pgs subtitles, btw.

Hendrik · « **Reply #2 on:** May 11, 2024, 01:25:38 am »

Odd, it should start on the left, why would it cut off there. I'll try to check it out.

Drybonz · « **Reply #3 on:** May 12, 2024, 09:32:31 pm »

This happens all the time in portions of subtitles that are in italics.

Hendrik · « **Reply #4 on:** May 17, 2024, 04:16:19 am »

I've been working on fixing this for text subtitles, it was caused by the drop shadow not being properly accounted for in text layouting. If this happens with bitmap subtitles like PGS that would be a very different issue, and please do report a sample if this happens.

Ashfall · « **Reply #5 on:** May 17, 2024, 09:31:17 am »

Quote from: Hendrik on May 17, 2024, 04:16:19 am

I've been working on fixing this for text subtitles, it was caused by the drop shadow not being properly accounted for in text layouting. If this happens with bitmap subtitles like PGS that would be a very different issue, and please do report a sample if this happens.

That's great, thanks!
I never noticed it in PGS subs, but will keep a lookout.

Drybonz · « **Reply #6 on:** May 20, 2024, 02:03:06 pm »

Looks like this didn't fix the issue for italics portions of .srt subs. They are still cut off on the edges.

Hendrik · « **Reply #7 on:** May 20, 2024, 03:56:17 pm »

The fix is not available in a build yet. It'll be included in 32.0.48 and newer.

eve · « **Reply #8 on:** May 20, 2024, 04:49:50 pm »

Quote from: Hendrik on May 20, 2024, 03:56:17 pm

The fix is not available in a build yet. It'll be included in 32.0.48 and newer.

Thank you. This has been present for a while.

This should fix image based and text based subs correct?

Drybonz · « **Reply #9 on:** May 20, 2024, 05:30:51 pm »

Quote from: Hendrik on May 20, 2024, 03:56:17 pm

The fix is not available in a build yet. It'll be included in 32.0.48 and newer.

Oh... sorry about that. I thought I had seen it in the changelog.

Hendrik · « **Reply #10 on:** May 20, 2024, 11:07:02 pm »

Quote from: eve on May 20, 2024, 04:49:50 pm

This should fix image based and text based subs correct?

This only fixes text based subs, as I explained above the issue was specific to rendering the drop shadows and not actually reserving space for them. If such a problem exists with image based subs it'll be a rather different problem, and I would need an example of it.

Ashfall · « **Reply #11 on:** May 21, 2024, 10:17:45 am »

PGS looks fine to me. I've tried to find candidates where the problem would show, but so far no problems.

bogdanbz · « **Reply #12 on:** May 24, 2024, 01:08:28 pm »

Thank you for fixing the text subtitle issue!

I remember having encountered pgs subtitles with the same issue, but I did not keep samples around. If I stumble again upon an example, I'll post it.

Ashfall · « **Reply #13 on:** May 24, 2024, 09:26:55 pm »

The fix works great, thanks!

Ashfall · « **Reply #14 on:** June 24, 2024, 12:11:57 pm »

Sorry to bring this up again, but I noticed that SRT subs are also cutoff on the right side sometimes. It only seems apparent when it's italics that ends in a quote, like the image below.

Hendrik · « **Reply #15 on:** June 25, 2024, 02:54:09 am »

That should also be fixed in a future build, having any formatting (italics or bold) at the end of the line caused the extra spacing to be ignored (because it terminated the formatting, inserting an empty text token, which consumed the padding .. it was an entire thing).

Ashfall · « **Reply #16 on:** June 27, 2024, 07:30:50 am »

32.0.58 almost fixed it. Just a few more pixels!

bogdanbz · « **Reply #17 on:** June 27, 2024, 04:55:39 pm »

Here's an example of a text subtitle with italics that has both the front and the end cut off. This is with build 55, btw.

Install the fonts from the archive (install them for the local user, not system wide) if you can't reproduce the issue. (and MC may need to be restarted to take effect)

Place this in a srt file and use it with any video file:

Code: [Select]

1
00:00:01,382 --> 00:05:00,383
<i>Azi?</i>

Configure the fonts for text based subtitles in MC this way:
Font: Trebuchet MS
Font Style: Bold
Size: 12

The end result is what can be seen in the attached screenshot, where both the leading "A" and the ending question mark are truncated.

Ashfall · « **Reply #18 on:** June 27, 2024, 07:51:32 pm »

Good info bogdanbz.

I have to add endquotes to see it cutoff on the right, but don't the left is still cutoff with an italicized uppercase A. This is 32.0.58.

Click the image for fullsize:

Hendrik · « **Reply #19 on:** June 28, 2024, 11:40:33 am »

Seems like in these cases the issue wasn't limited to just the drop shadow, so I made some more fundamental changes to ensure fonts reserve the right amount of space when they produce what the font engine calls "overhang" (due to italics or whatever), but due to the nature of the change it'll need some more testing and take a while to show up.

bogdanbz · « **Reply #20 on:** July 06, 2024, 11:43:17 am »

Ok, thank you!

That subtitle line is from "Scavenger's Reign", btw, I was watching it and I couldn't stop myself from writing down the time when it happened to go back and report this.

I did not manage to reproduce the issue with PGS subtitles anymore, maybe I was mistaken and it always happened only with text subtitles.

INTERACT FORUM

Author Topic: Subtitles Cut Off (Read 1982 times)