INTERACT FORUM

Please login or register.

Login with username, password and session length
Advanced search  
Pages: [1]   Go Down

Author Topic: To LCtheDJ - Comment tags  (Read 1279 times)

Nikolay

  • Regular Member
  • Citizen of the Universe
  • *****
  • Posts: 1681
  • Former CTO, JRiver, Inc.
To LCtheDJ - Comment tags
« on: September 05, 2002, 10:57:09 am »


MJ's .ogg tagging is still using "DESCRIPTION" instead of "COMMENT" for the comment field label. If MJ is supposed to support some of Winamp's plugins, shouldn't it use the same standards that those plugins use?


"COMMENT" field is not in the list of official ogg fields. You will have to talk to Winamp guys to fix that.
http://www.xiph.org/ogg/vorbis/doc/v-comment.html


Besides the conflict with ogg's COMMENT, there is also the ID3V2.3 conflict of using MJ's "COMM" vs the standard "TCOM" label for comments.


From ID3Lib project:
 {ID3FID_COMMENT, "COMM", "Comments"},
 {ID3FID_COMPOSER, "TCOM", "Composer"},
http://www.id3lib.org/id3/id3v2.3.0.txt

Nikolay
Logged

LCtheDJ

  • Guest
RE:To LCtheDJ - Comment tags
« Reply #1 on: September 05, 2002, 01:51:36 pm »

Thank you for the links.

After doing some more tagging and comparing between MJB and Winamp, I've discovered that (today) BOTH are using COMM for Comments, and BOTH are using TCOM for Composer.  My apologies on that point.  Apparently I can get lost trying to read an ID3 tag in a hex editor.

I see at xiph that a "COMMENT" field is NOT in the list of official ogg fields.  But "DESCRIPTION" is, and MJ is using that and giving it the title "Comments", which only leads to confusion (at least mine).  If you want to make up your own field names, that's fine; but please, don't take an existing one and call it something else.  Why don't you use the field name "COMMENTS" for Comments, since DESCRIPTION is reserved for "A short text description of the contents"?  Or, if you want to continue using DESCRIPTION, change the field title display in MJ to "Description"?

Thanks for the reply, and again, sorry for my mistake.
Logged

LCtheDJ

  • Guest
RE:To LCtheDJ - Comment tags
« Reply #2 on: September 05, 2002, 01:59:49 pm »

PS

One thing I discovered that seems a little quirky: When I change the Comment and save in MJ, the old Comment is not changed in the tag. The old one is still there and another COMM entry is added to the tag. My test file now has 4 COMM entries, each with different data.
Logged

LCtheDJ

  • Guest
RE:To LCtheDJ - Comment tags
« Reply #3 on: September 05, 2002, 02:03:02 pm »

PPS

The ID3v2.3 tag gets multiple COMM entries; the ID3v1 tag gets updated. Winamp reads the ID3v1 tag OK, but only reads the first COMM entry in the ID3v2.3 tag, which is not the most recent entry.
Logged

Nikolay

  • Regular Member
  • Citizen of the Universe
  • *****
  • Posts: 1681
  • Former CTO, JRiver, Inc.
RE:To LCtheDJ - Comment tags
« Reply #4 on: September 06, 2002, 11:18:50 am »

LCtheDJ,

The multiple COMM entries problem will be fixed in next build.

Nikolay
Logged

LCtheDJ

  • Guest
RE:To LCtheDJ - Comment tags
« Reply #5 on: September 06, 2002, 09:22:55 pm »

I tested the tagging in 8.0.365 and found it works correctly and even cleaned up the previous errors - now only one COMM entry per ID3 tag.

Thanks Nikolay!
Logged

LCtheDJ

  • Guest
RE:To LCtheDJ - Comment tags
« Reply #6 on: September 07, 2002, 12:33:55 pm »

Could you comment on the practice of taking the tag "DESCRIPTION" and calling it "Comment" instead of calling it "Description"?

How about having data entered under "Comment" go to a field labeled "COMMENT" instead of to one labeled "DESCRIPTION"?  This would make MJ compatible with my other audio tools.
Logged

LCtheDJ

  • Guest
RE:To LCtheDJ - Comment tags
« Reply #7 on: September 10, 2002, 05:49:59 pm »

bump
Logged
Pages: [1]   Go Up