INTERACT FORUM

Please login or register.

Login with username, password and session length
Advanced search  
Pages: [1]   Go Down

Author Topic: Wavpack Plugins Released  (Read 3286 times)

scthom

  • Citizen of the Universe
  • *****
  • Posts: 621
Wavpack Plugins Released
« on: July 04, 2007, 10:03:47 pm »

I've posted new versions of both the Encoder and Decoder plugins for Wavpack.  http://mcplugins.sourceforge.net.

The encoder has a slight change to the handling of input file sizes and calculated number of samples.  MC sometimes passes incorrect file sizes, which can throw off the calculated samples.  I'm now leaving it as -1 and updating the first block with the correct number afterward.  It never threw off the decoder because the decoder reads the first and last blocks and takes the difference.

The decoder had a bug in the PushBackCallback function which caused the first block to be skipped.  Typically this block was 22050 samples (44100 bytes at 16 bits per).
Logged

GHammer

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 1930
  • Stereotypes are a real timesaver!
Re: Wavpack Plugins Released
« Reply #1 on: July 08, 2007, 11:35:25 pm »

Sorry for the slow report, but the downloads page gives the old version:
http://downloads.sourceforge.net/mcplugins/In_Wavpack-V2.1.0.zip

If I ask for 2.2.1 I get a zero byte file.
Logged

scthom

  • Citizen of the Universe
  • *****
  • Posts: 621
Re: Wavpack Plugins Released
« Reply #2 on: July 09, 2007, 09:30:21 am »

Thanks for the heads-up.  I'll try to get it fixed tonight after work.
Logged

Alex B

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 10121
  • The Cosmic Bird
Re: Wavpack Plugins Released
« Reply #3 on: July 09, 2007, 09:44:41 am »

Thanks for your efforts, scthom.

I was about to test test the corrected filesize/playback time writing and reporting, but before I got started I noticed something else. The APE tag writing system has a serious problem.

The first "APETAXED" string is missing and the plugin does not write compatible tags.

If the tags are created outside MC12 the plugin cannot read them at all. When I tried to retag old files I ended up with two separate APE tag blocks.
Logged
The Cosmic Bird - a triple merger of galaxies: http://eso.org/public/news/eso0755

GHammer

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 1930
  • Stereotypes are a real timesaver!
Re: Wavpack Plugins Released
« Reply #4 on: July 09, 2007, 11:22:02 pm »

I was about to test
So you are able to download this version?
I get the old version still.
Cleared cache, tried another browser.
Logged

scthom

  • Citizen of the Universe
  • *****
  • Posts: 621
Re: Wavpack Plugins Released
« Reply #5 on: July 10, 2007, 12:07:47 am »

I was about to test test the corrected filesize/playback time writing and reporting, but before I got started I noticed something else. The APE tag writing system has a serious problem.

The first "APETAXED" string is missing and the plugin does not write compatible tags.

If the tags are created outside MC12 the plugin cannot read them at all. When I tried to retag old files I ended up with two separate APE tag blocks.

It's (way too entirely) possible, but I use Matt's library (modified only very slightly) to read/write tags, so I suspect there's more to it.
Logged

scthom

  • Citizen of the Universe
  • *****
  • Posts: 621
Re: Wavpack Plugins Released
« Reply #6 on: July 10, 2007, 12:30:41 am »

The links are now fixed.  Sorry!
Logged

Alex B

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 10121
  • The Cosmic Bird
Re: Wavpack Plugins Released
« Reply #7 on: July 10, 2007, 09:51:27 am »

So you are able to download this version?
I get the old version still.
Cleared cache, tried another browser.

I downloaded it from the Sourceforge page.

It's (way too entirely) possible, but I use Matt's library (modified only very slightly) to read/write tags, so I suspect there's more to it.

You suspect? So you didn't try to reproduce the problem or are you saying that you can't reproduce it?

I used foobar, Mp3tag and a hexeditor for checking my test files.
Logged
The Cosmic Bird - a triple merger of galaxies: http://eso.org/public/news/eso0755

GHammer

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 1930
  • Stereotypes are a real timesaver!
Re: Wavpack Plugins Released
« Reply #8 on: July 10, 2007, 12:10:04 pm »

The links are now fixed.  Sorry!
I'm just not living right then. Here's the error I get from sourceforge:


Code: [Select]
An error has been encountered in accessing this page.

1. Server: mcplugins.sourceforge.net
2. URL path: /packages/In_Wavpack.mjp
3. Error notes: File does not exist: /home/groups/m/mc/mcplugins/htdocs/packages/In_Wavpack.mjp
4. Error type: 404
5. Request method: GET
6. Request query string:
7. Time: 2007-07-10 10:08:22 PDT (1184087302)
Logged

Alex B

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 10121
  • The Cosmic Bird
Re: Wavpack Plugins Released
« Reply #9 on: July 10, 2007, 01:08:24 pm »

I got the same error message.

The encoder plugin link goes a bit further. The Enc_Wavpack.mjp file is found, but the installer cannot download the zip package. It just creates an empty "WavPack Encoder" folder in my temp directory.

I downloaded the plugin packages directly from here:
http://sourceforge.net/project/showfiles.php?group_id=161914,
unzipped and used the "Local_Install.mjp" files.
Logged
The Cosmic Bird - a triple merger of galaxies: http://eso.org/public/news/eso0755

scthom

  • Citizen of the Universe
  • *****
  • Posts: 621
Re: Wavpack Plugins Released
« Reply #10 on: July 10, 2007, 09:07:24 pm »

I could swear I fixed it last night.

Case problems with the file names.  They both work fine now.
Logged

scthom

  • Citizen of the Universe
  • *****
  • Posts: 621
Re: Wavpack Plugins Released
« Reply #11 on: July 10, 2007, 09:36:30 pm »

You suspect? So you didn't try to reproduce the problem or are you saying that you can't reproduce it?

I used foobar, Mp3tag and a hexeditor for checking my test files.

I haven't been able to duplicate it, but as of yet I haven't tried anything except MC and a hex editor.  I don't use wavpack at all and only have standard test files for audio decoding.

Matt's library hasn't changed, I haven't changed it, and it checks for valid APE tags (it looks for "APETAGEX" during the IsValid routine).  Did it work properly before?  I don't think anything has changed on my end.

Maybe it's a UTF encoding / byte size problem? (Where something is off by a byte or two)  Any multi-byte characters in the tags?
Logged

GHammer

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 1930
  • Stereotypes are a real timesaver!
Re: Wavpack Plugins Released
« Reply #12 on: July 10, 2007, 11:11:30 pm »

I got the new release installed and can confirm that existing tags are not recognized.
Duration and bitrate are shown correctly. No other info though.
Didn't try tagging as it was already reported to be broken.
Logged

scthom

  • Citizen of the Universe
  • *****
  • Posts: 621
Re: Wavpack Plugins Released
« Reply #13 on: July 13, 2007, 12:11:04 am »

FYI, I was able to finally duplicate the issue.  There are 4 extra bytes being added.  I'm working on figuring it out.  It is possible to edit the files without losing any tags by just deleting the 4 bytes at the beginning of the APE footer and adding 4 null bytes ("00") to the end.
Logged
Pages: [1]   Go Up