Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[RhinoBanga]

Guys,

Looks like you've left in some OutputDebugString messages in your new ASPI layer.

When debugging AV2 I get loads of:

[3488] AKRip32: SCSIPT: Checking drive E:
[3488] AKRip32: SCSIPT: GetFileHandle(): Setting for Win2K
[3488] akrip32: scsipt: CreateFile() returned 0
[3488]        : Index 4: fh == 000000BC
[3488] Device E: Port=0, PathId=0, TargetId=0, Lun=0
[3488] AKRip32: SPTI: Adding drive E: (0:0:0)
[3488] AKRip32: SCSIPT: Checking drive F:
[3488] AKRip32: SCSIPT: GetFileHandle(): Setting for Win2K
[3488] akrip32: scsipt: CreateFile() returned 0
[3488]        : Index 5: fh == 000000C4
[3488] Device F: Port=0, PathId=0, TargetId=1, Lun=0
[3488] AKRip32: SPTI: Adding drive F: (0:1:0)
[3488] AKRip32: SCSIPT: Checking drive G:
[3488] AKRip32: SCSIPT: GetFileHandle(): Setting for Win2K
[3488] akrip32: scsipt: CreateFile() returned 0
[3488]        : Index 6: fh == 000000B4
[3488] Device G: Port=1, PathId=0, TargetId=0, Lun=0
[3488] AKRip32: SPTI: Adding drive G: (1:0:0)
[3488] AKRip32: SPTIGetASPI32SupportInfo
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex
[3488] AKRip32: SPTIGetDeviceIndex

[Matt]

Bad news bears.

JohnT (the JRiver CD whiz) is gone for a couple weeks on vacation.

We'll clean it up when he gets back.

-Matt
JRiver, Inc.

[RhinoBanga]

No problem Matt.

But on another issue I cannot disable skinning just before I return from Init:

STDMETHODIMP CAlbumViewCtrl::Init( LPDISPATCH pDisp )
{
   AFX_MANAGE_STATE( AfxGetStaticModuleState() )

   //  Save the window
   AlbumView::m_hWnd = m_hWnd;

   //  Perform the main initialization
   AlbumView::MainInitialization();

   //  Call the real initialize routine
   AlbumView::Init( pDisp );

   //  Switch off skinning
   AlbumView::m_pMJ->EnableSkinning( false );

   return S_OK;
}



Any ideas?

[Matt]

It seems like skinning should be an option the plugin can put in the registry.  That would be less sloppy...

Until then, if you handle WM_CREATE, you may be able to toggle it.

So,

CAlbumViewWnd::OnCreate(...)
{
  m_pMJ->EnableSkinning(FALSE);
  CWnd::OnCreate(...);
  m_pMJ->EnableSkinning(TRUE);
}

Also, I hate that EnableSkinning(...) doesn't return a state.  It should be:

CAlbumViewWnd::OnCreate(...)
{
  BOOL bOriginalSkinningState = m_pMJ->EnableSkinning(FALSE);
  CWnd::OnCreate(...);
  m_pMJ->EnableSkinning(bOriginalSkinningState);
}

So much to do... so little time

-Matt

[RhinoBanga]

Matt,

> So much to do... so little time

I know what you mean


Off the top of my head won't OnCreate get called before Init therefore the m_pMJ pointer is invalid?   Also I thought the EnableSkinning was on a per plugin basis anyway?



Jamie.

[Matt]

Init(...) should get called before Create(...)

And EnableSkinning(...) isn't per plugin... it's global.  I know... a little sloppy.

-Matt