INTERACT FORUM

Please login or register.

Login with username, password and session length
Advanced search  
Pages: [1]   Go Down

Author Topic: Playing now shuffles after playing the last song  (Read 488 times)

Marty3d

  • Citizen of the Universe
  • *****
  • Posts: 1363
Playing now shuffles after playing the last song
« on: January 06, 2021, 07:29:33 am »

Is this an intended behaviour, that after you play the last song in Playing Now, it shuffles everything before stopping? It's not a biggie and there's probably a setting for it somewhere (where?) but it feels weird :)

Thanks!
Logged


JimH

  • Administrator
  • Citizen of the Universe
  • *****
  • Posts: 72380
  • Where did I put my teeth?
Re: Playing now shuffles after playing the last song
« Reply #1 on: January 06, 2021, 07:55:15 am »

No.  Is shuffle on?  Check the little icons in the upper right corner.
Logged

Marty3d

  • Citizen of the Universe
  • *****
  • Posts: 1363
Re: Playing now shuffles after playing the last song
« Reply #2 on: January 06, 2021, 08:26:24 am »

Hi Jim, thanks for your reply!
Yes, shuffle is on, it doesn't happen when it's off.

I did some more tests and it's reproducible:
- Add a few songs to playing now
- Turn on shuffle
- Play the last song and skip to near the end
= When the song stops, Playing now shuffles

Logged


Matt

  • Administrator
  • Citizen of the Universe
  • *****
  • Posts: 42323
  • Shoes gone again!
Re: Playing now shuffles after playing the last song
« Reply #3 on: January 06, 2021, 11:37:26 am »

Thanks!  I can reproduce it.  I'll investigate and follow-up later.
Logged
Matt Ashland, JRiver Media Center

Matt

  • Administrator
  • Citizen of the Universe
  • *****
  • Posts: 42323
  • Shoes gone again!
Re: Playing now shuffles after playing the last song
« Reply #4 on: January 06, 2021, 11:41:09 am »

It looks like it's by design.

Here's the code comment:
// shuffle if we just played the last track and we're in shuffle mode

I guess we figure since it's in shuffle, it makes sense to reshuffle after the last track.

I don't have a strong opinion.  Anybody else care to vote?

Thanks.
Logged
Matt Ashland, JRiver Media Center

glynor

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 19608
Re: Playing now shuffles after playing the last song
« Reply #5 on: January 06, 2021, 11:47:32 am »

I think it only makes sense if it is going to continue playing. Shuffling and then Stopping is dumb (and erases the playlist that just played, which I use sometimes to go back and find out what song played that I liked 3 songs ago).

So, I'd say do that, but only if Continuous Mode is also enabled, such that reshuffling will actually, you know, accomplish something.
Logged
"Some cultures are defined by their relationship to cheese."

Visit me on the Interweb Thingie: http://glynor.com/

Marty3d

  • Citizen of the Universe
  • *****
  • Posts: 1363
Re: Playing now shuffles after playing the last song
« Reply #6 on: January 06, 2021, 01:07:27 pm »

I don't have a strong opinion either, but:
Quote
(and erases the playlist that just played, which I use sometimes to go back and find out what song played that I liked 3 songs ago)
This I completely agree on, actually what made me react :)
Logged


Matt

  • Administrator
  • Citizen of the Universe
  • *****
  • Posts: 42323
  • Shoes gone again!
Re: Playing now shuffles after playing the last song
« Reply #7 on: January 06, 2021, 01:44:33 pm »

Next build:
Changed: The shuffle at the end of the playlist when shuffle mode is on will only fire if playback is set to advance to the first track again.
Logged
Matt Ashland, JRiver Media Center

Marty3d

  • Citizen of the Universe
  • *****
  • Posts: 1363
Re: Playing now shuffles after playing the last song
« Reply #8 on: January 07, 2021, 01:33:57 am »

Thanks Matt!
Logged


Pages: [1]   Go Up