INTERACT FORUM

Please login or register.

Login with username, password and session length
Advanced search  
Pages: [1]   Go Down

Author Topic: NEW: HDCD Detection  (Read 1242 times)

Matt

  • Administrator
  • Citizen of the Universe
  • *****
  • Posts: 42387
  • Shoes gone again!
NEW: HDCD Detection
« on: June 18, 2019, 11:48:32 am »

A coming build of Media Center will add HDCD detection to the audio analyzer.

Just run the tool on any files you think might be HDCD and it will check the box (for decoding) on any matches.

Earlier in MC25 we added HDCD decoding to playback the 16-bit HDCD files as 24-bit.

This was a fun one for us to add :)
Logged
Matt Ashland, JRiver Media Center

dtc

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 3119
Re: NEW: HDCD Detection
« Reply #1 on: June 18, 2019, 12:33:48 pm »

Very nice  :)
Logged

dtc

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 3119
Re: NEW: HDCD Detection
« Reply #2 on: June 18, 2019, 12:46:37 pm »

If you have already run the analyzer on the file, will it just do the HDCD detection?
Logged

Hendrik

  • Administrator
  • Citizen of the Universe
  • *****
  • Posts: 10943
Re: NEW: HDCD Detection
« Reply #3 on: June 18, 2019, 05:01:10 pm »

If you have already run the analyzer on the file, will it just do the HDCD detection?

No, it'll always run the full process. There are various reasons to want to re-analyze, so differentiating that would be annoying.
Logged
~ nevcairiel
~ Author of LAV Filters

Scobie

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 740
  • Looking Busy
Re: NEW: HDCD Detection
« Reply #4 on: June 18, 2019, 06:05:01 pm »

Great addition, well done to all involved.
Logged

dtc

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 3119
Re: NEW: HDCD Detection
« Reply #5 on: June 18, 2019, 06:24:00 pm »

Hendrik - Actually, have 2 check boxes - one for volume leveling and one for HDCD - would seem pretty simple. And it would avoid the time consuming process of doing the R128 calculation each time. If you want to do both, just keep both boxes checked. Flexibility for the user is a good thing.
Logged

Hendrik

  • Administrator
  • Citizen of the Universe
  • *****
  • Posts: 10943
Re: NEW: HDCD Detection
« Reply #6 on: June 18, 2019, 07:33:08 pm »

The way I see it, this "flexibility" is not very useful in the long-run, its a one-time checkbox you would use now, and never again. As such, I don't see the value in it. Flexibility is only good to a point, after which you produce feature creep, which overloads interfaces, confuses users, and increases maintenance burdens.

Also, Audio Analysis does more then just volume measurements. How many checkboxes are acceptable?
Logged
~ nevcairiel
~ Author of LAV Filters

dtc

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 3119
Re: NEW: HDCD Detection
« Reply #7 on: June 18, 2019, 08:24:18 pm »

For somebody with a large library it can a long time to run auto analyze.  It seems like it makes sense to exclude analyzing items that have already been done. Maybe just 1 check box option  - Do Not Repeat Analysis That Has Already Been Done.

I understand not providing an option for everything. But it seems appropriate to allow users to avoid an action that they do not want so they can do another action they do want. Some linkages are appropriate, some are not. This seems like one where an option to unlink some actions would be appropriate.

Matt and I have also discussed another such linkage - automatically looking up lyrics for tracks with no lyrics when you display lyrics. Again, this seems like actions that should not be linked without an option to unlink them. Having to do one in order to do the other forces users to do actions they do not want to do.

Just my thoughts.


Logged

dtc

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 3119
Re: NEW: HDCD Detection
« Reply #8 on: June 18, 2019, 09:20:49 pm »

Just checked - Analyze Audio already has a check box to skip files that have already been analyzed. Shouldn't that apply to files that already have R128 values in the library? I think that is the default.

EDIT : The answer is NO. If a previous analysis has been done, the analysis will not run with the Skip box checked. You have to rerun the  previous analysis if you want to do HDCD detection. Sorry, but that just does not make sense.  The two types of analysis are simply not related.
Logged

dtc

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 3119
Re: NEW: HDCD Detection
« Reply #9 on: June 18, 2019, 09:28:37 pm »

What else does it do other than the R128 calculations? That is what I am referring to.
Logged

dtc

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 3119
Re: NEW: HDCD Detection
« Reply #10 on: June 19, 2019, 04:40:09 pm »

Note by R128/volume level calculations I am referring to the current calculation. There may be a more appropriate term that find. Just want to be clear what I am referring to.

To summarize:

HDCD and the current R128/volume level calculations are completely independent of one another.

There are only two options involved here - the existing analysis and HDCD. There are not multiple analyses to be consider, just the two.

Two check boxes - one for the existing analysis and one for HDCD check is all that is needed.

Or you can maintain the one existing check box by changing the wording to -  Skip R128/volume level calculations and HDCD check when there is existing data.  That would skip the existing calculations (R128/volume leveling and HDCD check) if there is data that shows the analysis has already been done.  Same number of check boxes - but more functional given the addition of the HDCD check.

If you want to make the HDCD check more efficient, a -1 in the HDCD tag could show that the analysis has been done and no HDCD was found.

Sorry to be so persistent. But, to me, obviously, doing hours of repetitive calculations that produce nothing new seems unnecessary.  I think there are ways to make this more efficient without unduly complicating the interface.

If you do not want to do the two box solution, at least consider change the existing check box to be more functional given the addition of the HDCD option.
Logged

JimH

  • Administrator
  • Citizen of the Universe
  • *****
  • Posts: 72444
  • Where did I put my teeth?
Re: NEW: HDCD Detection
« Reply #11 on: June 19, 2019, 04:48:26 pm »

Does anybody else care much?
Logged

dtc

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 3119
Re: NEW: HDCD Detection
« Reply #12 on: June 19, 2019, 05:04:18 pm »

I am just trying to point out the potential problems. The current implementation is flawed. 

Honestly, I would think you would care about these problems. It is a quick fix to deal with now. Down the road it will never get dealt with.
Logged

jmone

  • Administrator
  • Citizen of the Universe
  • *****
  • Posts: 14465
  • I won! I won!
Re: NEW: HDCD Detection
« Reply #13 on: June 20, 2019, 04:40:41 am »

Does anybody else care much?

So I scanned my 10K ish audio files and was surprised to find about 2% were HDCD (which is nice).  It took abit over an hour to do this which was (for me) OK.  What I liked less was that every single file was updated (which I'm now pushing to my backup).  I doubt that 100% of the files did actually need to be updated, but maybe I'm wrong.  I would suggest that tags are only updated if they are actually different. 
Logged
JRiver CEO Elect

Matt

  • Administrator
  • Citizen of the Universe
  • *****
  • Posts: 42387
  • Shoes gone again!
Re: NEW: HDCD Detection
« Reply #14 on: June 20, 2019, 08:44:32 am »

I am just trying to point out the potential problems. The current implementation is flawed. 

Honestly, I would think you would care about these problems. It is a quick fix to deal with now. Down the road it will never get dealt with.

Next build will have this change:
Changed: Made the HDCD field a string that defaults to -1 to mean not analyzed.  It can be set to 0 or 1 after analysis.
Logged
Matt Ashland, JRiver Media Center

dtc

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 3119
Re: NEW: HDCD Detection
« Reply #15 on: June 20, 2019, 12:53:36 pm »

Matt - With that, if the check for previous analysis is applied separately to the existing r128/volume leveling calculation and the HDCD detection, that eliminates the issue of having to re-analyze files that have already been analyzed. Hope that is the plan.

Does the default get applied to existing files if the field is blank?

Thanks.

Logged

dtc

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 3119
Re: NEW: HDCD Detection
« Reply #16 on: June 20, 2019, 05:20:37 pm »

Seems to work as expected. Thanks for the change  :)
Logged

Craig

  • MC Beta Team
  • Citizen of the Universe
  • *****
  • Posts: 612
Re: NEW: HDCD Detection
« Reply #17 on: July 04, 2019, 02:49:53 am »

Out of curiosity I re analysed my library and it found nine albums but it only flagged up two tracks from Keb' Mo's album Slow Down as HDCD, is this possible or is it an error?

Craig
Logged
MC2Slim - Windows Shell and JRiver Media Center Integration for Squeezebox.

http://www.duff-zapp.co.uk
Pages: [1]   Go Up