Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[RD James]

I see that MC now defaults to using the Modern Cards skin (possibly an updated version?) which looks nice, but whoever built it must not use split views.
When you are using a split view, Modern Cards does not show any way to expand, collapse, or resize the splits. All three skins are affected.

[Awesome Donkey]

Hmmm, yeah, you're right. Modern Cards purposely uses the absolute minimum size when it comes to splitters (2 px) without any triangle arrows to collapse/expand it. Looking at the skin's main.xml I see this (along with the comments);

Code: [Select]

<!-- NOTE: The default splitter takes up to much space. Yes, it's a bit more difficult to hit with it at 2 px, but it's still usable. In this skin it's matching the tree background color. There's one "issue" with this though. Views where you've got a pane to the side of the list, you'll get a 2px dark border that doesn't match the list background color. There's nothing that can be done about this, short of removing the splitter completely.  -->
<SPLITTER>
<Data DefaultSize="1" />
<Entry Name="HorizontalBackground" Bitmap="Splitter_Background_H.png" Margins="9,1,9,1" Columns="398,?-Flex,398" />
<Entry Name="VerticalBackground" Bitmap="Splitter_Background_V.png" Rows="23,?-Flex" />
<Entry Name="HorizontalHandle" Bitmap="Splitter_Horizontal.png" Margins="2,1,1,1" DrawMode="REGION_E_HTILE,REGION_E_VTILE" />
<!-- TODO: Is there any way to make sure the "triangle" control doesn't show up in a splitter, without having to make "VericalHandle" a stupidly tall image? There probably is, but how?! -->
<Entry Name="VerticalHandle" Bitmap="Splitter_Vertical.png" Margins="1,2,1,1" DrawMode="REGION_E_HTILE,REGION_E_VTILE" />
</SPLITTER>
I agree with the part about the default splitter taking up too much space, but it looks like the skin doesn't (or most likely can't) account for split view being used. Also looks like this could be an unfinished portion of the skin, not sure, since the triangles are purposely blocked/not used. Unlike the tree splitter, looks like you can't double click on the split view splitters to collapse/expand them AND the split views when collapsed don't appear correctly. Not sure if there's an easy way around this, short of restoring larger splitters with the triangles which *could* look terrible with this skin. Sadly, this is likely outside of my current ability to fix/workaround as I've yet to work with splitters.

[marko]

I may try and have a look at this later today. Without some change to the code to force a splitter, the only way I see around this is to put a vertical splitter in the skin.

Dirhael also notes that he was looking for a way to make the triangles disappear. You can't (currently). You can, however, control their appearance via the 'splitter' entry in the 'mainframe' data of the xml. If you make them the same colour as the splitter, they effectively, disappear.

Have a look at, for example, my arctic winter (HC) skin (Link).
I found that here, the splitter is still functional, but almost invisible unless you're looking for it. Between 6 and 10 pixels wide is optimal, I think, with 6 being best while still retaining function.

Other thoughts...
There's an option that allows the scroll bar to 'grow' when we hover over it. Personally, I don't like it and have it turned off, but maybe something along those lines could be made to work for the splitters too?

-marko

[Awesome Donkey]

I may try and have a look at this later today.

If you do manage to fix/workaround this, please let me know what the changes are so I can backport them to the Linux ModernCards skins and the modded Light Edition skin.

There's an option that allows the scroll bar to 'grow' when we hover over it. Personally, I don't like it and have it turned off, but maybe something along those lines could be made to work for the splitters too?

Now this would be kinda interesting to see.

[marko]

Subtle, right?

If the attached passes muster, the files and updated xml are in the zip file...

-marko.

[Awesome Donkey]

Yep, it'll do. And only three modified lines in main.xml too, nice! Thanks!

I'll work on backporting these to the other skins immediately.

[Hendrik]

Let me know when you have the changes for all three Modern Cards skins, and I'll put it in the next build.

[Awesome Donkey]

Done. Here, give these a go and tell me what you think.

https://www.filefactory.com/file/1ma3o90u39yb/ModernCardsSplitterFixes.zip

[marko]

Yep, it'll do. And only three modified lines in main.xml too, nice! Thanks!

I'll work on backporting these to the other skins immediately.

Four lines. Watch for the colour changes in the main frame section, on line 88, as well as the three lines in the splitter section.

marko.

[Awesome Donkey]

Four lines. Watch for the colour changes in the main frame section, on line 88, as well as the three lines in the splitter section.

Hmmm, I got line 88 and lines 510 and 511, what's the last one (my comparison tool didn't pick it up)?

[Hendrik]

I also only saw 2 lines in the splitter section, but it looks fine to me.

[marko]

Ignore me

I thought I'd changed the matrix for the vertical background, but I didn't. Three lines it is.

[Awesome Donkey]

Hmmm, something occurs to me (going on what Marko said above about having the triangles essentially disappearing by setting them the same color as the splitter).

While we can change the color of the triangle (Shadow3DColor on line 88) I don't see a way that we can set a highlight color when hovering the mouse over the splitter (so they show if they're not easily visible). I tried setting Hilight3DColor but it doesn't do anything to highlight the triangle when hovering the mouse.

That way, we can set the triangle to be the same color as the splitter so they're essentially "invisible" unless you hover your mouse over the splitter (with maybe some transition fade in/animation effect so the triangles don't just "blink into existence"). I'm thinking that'd actually be pretty helpful with the ModernCards skins as we could "have our cake and eat it too" so to speak, IMO.

[marko]

I've never fully grasped these three values. See that they're also used in the frame title bar.

I believe thay can be used to create a pseudo 'bevel/embossed' look to objects they are applied to, but when I mess with them, they just made a mess for me!
I *think* that this hilight value refers to that, and is used in conjunction with face3d and shadow3d to create the effect, rather than a 'mouse over' effect.

-marko

[RD James]

It's subtle, but looking good.
I think it's important for the default skin to support all features even if it doesn't match the desired aesthetic.

[JimH]

Done. Here, give these a go and tell me what you think.

https://www.filefactory.com/file/1ma3o90u39yb/ModernCardsSplitterFixes.zip

Thanks very much for the help.